[codex] Structure VCS project config failures

[juliusmarminge]

Summary:

• retain inspect, read, and decode context for VCS project-config failures
• preserve original filesystem and schema causes while keeping the best-effort auto fallback
• verify structured logs for malformed and unreadable config paths

Tests:

• vp test apps/server/src/vcs/VcsProjectConfig.test.ts
• vp check
• vp run typecheck

---

Note

Low Risk
Changes are localized to VCS config discovery with preserved auto fallback; main effect is new warning logs on previously silent failures.

Overview
VCS project config resolution now surfaces inspect, read, and decode failures as VcsProjectConfigError (operation, cwd, configPath, original cause) instead of silently treating them as missing or invalid config.

resolveKind still falls back to auto, but emits structured warnings via logVcsProjectConfigError. JSON parsing uses decodeUnknownEffect so decode failures are typed errors, not Option.none. During parent walk, a failed exists check on a candidate path is logged and skipped so a valid parent .t3code/vcs.json can still be used.

Tests cover error shape, inspect-then-parent behavior, and warning log fields for malformed JSON and unreadable paths.

^{Reviewed by Cursor Bugbot for commit 569a697. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure VCS project config failures with typed errors and structured logging

• Introduces VcsProjectConfigError, a tagged error class carrying operation ('inspect' | 'read' | 'decode'), cwd, configPath, and cause, replacing silent Option.none fallbacks with typed failures.
• Adds logVcsProjectConfigError to emit structured warnings with operation, path, and stack context whenever config inspection, reading, or decoding fails.
• findConfigPath now catches inspect errors, logs them, and continues traversal to parent directories instead of aborting.
• resolveKind catches all VcsProjectConfigError variants, logs a structured warning, and falls back to 'auto' rather than propagating the failure.
• Behavioral Change: decode errors now fail the Effect pipeline rather than silently returning Option.none; all failure paths now produce log output.

^{Macroscope summarized 569a697.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e0c1229a-3970-497e-9747-f96f3c87f1bb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-vcs-project-config-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Inspect failures abort config discovery
  • Replaced Effect.mapError (which propagated the error and aborted the directory walk) with Effect.orElseSucceed(() => false) so that a failed fileSystem.exists is treated as 'not found' and the upward search continues to parent directories.

Or push these changes by commenting:

@cursor push 99690f3d5b

Preview (99690f3d5b)

diff --git a/apps/server/src/vcs/VcsProjectConfig.ts b/apps/server/src/vcs/VcsProjectConfig.ts
--- a/apps/server/src/vcs/VcsProjectConfig.ts
+++ b/apps/server/src/vcs/VcsProjectConfig.ts
@@ -62,17 +62,7 @@
     let current = cwd;
     while (true) {
       const candidate = path.join(current, ".t3code", "vcs.json");
-      const exists = yield* fileSystem.exists(candidate).pipe(
-        Effect.mapError(
-          (cause) =>
-            new VcsProjectConfigError({
-              operation: "inspect",
-              cwd,
-              configPath: candidate,
-              cause,
-            }),
-        ),
-      );
+      const exists = yield* fileSystem.exists(candidate).pipe(Effect.orElseSucceed(() => false));
       if (exists) {
         return Option.some(candidate);
       }

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 69d4522. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in VcsProjectConfig to use structured errors with better context (operation, cwd, configPath) for logging and debugging. Runtime behavior remains unchanged - errors still gracefully fall back to 'auto'. Tests thoroughly verify the new error structure.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 569a697