[codex] Structure missing client cloud config errors#3346
Conversation
Co-authored-by: codex <codex@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved This PR replaces generic Error throws with a structured CloudPublicConfigMissingError class in two locations. The error condition and message remain unchanged - this is purely a typing/structure improvement with added tests, carrying minimal risk. You can customize Macroscope's approvability policy. Learn more. |
Co-authored-by: codex <codex@users.noreply.github.com>
Dismissing prior approval to re-evaluate adbdcc0
Summary
Validation
Note
Replace generic errors with structured
CloudPublicConfigMissingErrorin web and mobile cloud configIntroduces
CloudPublicConfigMissingError, a tagged error class (viaeffect/Schema), in both the web and mobilepublicConfigmodules. WhenresolveRelayClerkTokenOptionscannot find the Clerk JWT template, it now throws this structured error instead of a plainError. Tests are added for both platforms to verify the new error type is thrown.Macroscope summarized adbdcc0.