Fix Linux Codex PATH resolution and tagged desktop artifact version#337
Fix Linux Codex PATH resolution and tagged desktop artifact version#337bczaplicki-gd wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # apps/desktop/src/fixPath.ts # apps/server/src/os-jank.ts
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: Fix Linux Codex PATH resolution and tagged desktop artifact version This is item 2/2 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
|
Closing because current shared shell hydration and tagged artifact/version machinery have superseded this conflicted implementation. This was closed as part of a large repo-wide maintenance sweep. If you think it's still relevant, please reopen. |
What this PR changes
This PR fixes two practical issues discovered while testing the Linux AppImage build:
codexon Linux even whencodexworks in terminal.Implementation notes
--build-versionHEAD(vX.Y.Z)How this was done
Validation performed
apps/desktop,apps/server,scripts).Context
This is focused on improving real-world release usability for Linux users launching AppImage from GUI environments.
Note
Update non-Windows PATH resolution in
apps/desktop/src/fixPath.tsandapps/server/src/os-jank.ts, and set desktop artifactappVersionfrom a Git tag inscripts/build-desktop-artifact.tsExtend
fixPathto run on all non-Windows platforms, try['-ilc', 'echo -n $PATH']then['-lc', 'echo -n $PATH']using$SHELLor platform defaults, and setprocess.env.PATHon first success; prefer a HEAD-pointing semver Git tag (withoutv) for desktop buildappVersion.📍Where to Start
Start with
fixPathin fixPath.ts, then review the mirrored changes in os-jank.ts; finally checkresolveGitTaggedVersionand its use in scripts/build-desktop-artifact.ts.Macroscope summarized 1bd0817.