Skip to content

Fix Linux Codex PATH resolution and tagged desktop artifact version#337

Closed
bczaplicki-gd wants to merge 1 commit into
pingdotgg:mainfrom
bczaplicki-gd:fix/appimage-codex-path-and-release-version
Closed

Fix Linux Codex PATH resolution and tagged desktop artifact version#337
bczaplicki-gd wants to merge 1 commit into
pingdotgg:mainfrom
bczaplicki-gd:fix/appimage-codex-path-and-release-version

Conversation

@bczaplicki-gd

@bczaplicki-gd bczaplicki-gd commented Mar 7, 2026

Copy link
Copy Markdown

What this PR changes

This PR fixes two practical issues discovered while testing the Linux AppImage build:

  1. The desktop app could fail to find codex on Linux even when codex works in terminal.
  2. Local desktop artifact builds from a tagged commit could still resolve to an older version number.

Implementation notes

  • Extended PATH bootstrap logic for desktop/server startup on Linux (while keeping Windows behavior unchanged).
  • PATH is now resolved from shell startup context with safe fallback behavior.
  • Updated desktop artifact version resolution order to prefer:
    1. explicit --build-version
    2. exact semver git tag on HEAD (vX.Y.Z)
    3. package fallback version

How this was done

  • Implemented with GPT-5.3 + Codex CLI.
  • Vibecoded, codex cli run some tests and said it was correct.

Validation performed

  • Linux AppImage builds were tested and are working on Ubuntu 24.04.
  • Type checks run for touched areas (apps/desktop, apps/server, scripts).
  • Built AppImage after fixes and confirmed expected behavior.

Context

This is focused on improving real-world release usability for Linux users launching AppImage from GUI environments.

Note

Update non-Windows PATH resolution in apps/desktop/src/fixPath.ts and apps/server/src/os-jank.ts, and set desktop artifact appVersion from a Git tag in scripts/build-desktop-artifact.ts

Extend fixPath to run on all non-Windows platforms, try ['-ilc', 'echo -n $PATH'] then ['-lc', 'echo -n $PATH'] using $SHELL or platform defaults, and set process.env.PATH on first success; prefer a HEAD-pointing semver Git tag (without v) for desktop build appVersion.

📍Where to Start

Start with fixPath in fixPath.ts, then review the mirrored changes in os-jank.ts; finally check resolveGitTaggedVersion and its use in scripts/build-desktop-artifact.ts.

Macroscope summarized 1bd0817.

@coderabbitai

coderabbitai Bot commented Mar 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b3847c3b-8190-4b89-bb88-0bf824782ca2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

rexlManu referenced this pull request in rexlManu/t3code-legacy Mar 7, 2026
# Conflicts:
#	apps/desktop/src/fixPath.ts
#	apps/server/src/os-jank.ts
@github-actions github-actions Bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Mar 9, 2026
@torturado

Copy link
Copy Markdown

ClawSweeper status: review started.

I am starting a fresh review of this pull request: Fix Linux Codex PATH resolution and tagged desktop artifact version This is item 2/2 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

Copy link
Copy Markdown
Member

Closing because current shared shell hydration and tagged artifact/version machinery have superseded this conflicted implementation.

This was closed as part of a large repo-wide maintenance sweep. If you think it's still relevant, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants