[codex] Structure Azure DevOps CLI failures

[juliusmarminge]

Summary

• replace the free-form AzureDevOpsCliError detail field with distinct schema-tagged command and decode failures
• classify command failures from structured VCS error data while retaining the immediate cause
• keep provider-facing messages stable and expose a union predicate for the complete error domain

Validation

• vp test apps/server/src/sourceControl/AzureDevOpsCli.test.ts apps/server/src/sourceControl/AzureDevOpsSourceControlProvider.test.ts
• vp check
• vp run typecheck

---

Note

Medium Risk
Callers that matched on the old single error class must handle the new union tags; classification behavior changes slightly (e.g. chdir NotFound vs missing az).

Overview
Replaces the single AzureDevOpsCliError with a union of schema-tagged classes (unavailable CLI, authentication, PR not found, generic command failure, and separate decode errors for PR list, PR view, and repository JSON).

fromVcsError now maps VcsError by structured fields (failureKind, spawn NotFound with chdir vs missing az) instead of parsing error strings. User-facing detail / message stay fixed per type; upstream text stays on cause. Command failures gain argumentCount; decode failures gain outputLength. isAzureDevOpsCliError is added for the union.

Tests assert the new types (including that a missing cwd is not misclassified as missing Azure CLI).

^{Reviewed by Cursor Bugbot for commit 5252104. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic Azure DevOps CLI errors with structured typed error classes

• Introduces specific error classes (AzureDevOpsCliUnavailableError, AzureDevOpsCliAuthenticationError, AzureDevOpsPullRequestNotFoundError, AzureDevOpsCommandFailedError, and decode errors for PRs and repositories) in AzureDevOpsCli.ts, replacing the previous single generic error type.
• Rewrites AzureDevOpsCommandFailedError.fromVcsError to classify failures by structured fields (e.g. failureKind, spawn NotFound with/without chdir syscall) instead of string matching.
• Adds outputLength and argumentCount to decode and command failure errors for richer diagnostics.
• Updates tests in AzureDevOpsCli.test.ts and AzureDevOpsSourceControlProvider.test.ts to assert on the new specific error classes and structured fields.
• Behavioral Change: callers handling the previous single error type now receive one of several specific error types from the exported AzureDevOpsCliError union.

^{Macroscope summarized 5252104.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e0ef62c0-b3b1-4083-a94b-621cdc93c781

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/azure-devops-cli-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Spawn NotFound mislabels missing cwd
  • Added two narrowing conditions (pathOrDescriptor !== context.cwd and syscall !== "chdir") to distinguish a missing az executable from a non-existent working directory, mirroring the pattern used in GitVcsDriverCore.

Or push these changes by commenting:

@cursor push 54a8bbd299

Preview (54a8bbd299)

diff --git a/apps/server/src/sourceControl/AzureDevOpsCli.ts b/apps/server/src/sourceControl/AzureDevOpsCli.ts
--- a/apps/server/src/sourceControl/AzureDevOpsCli.ts
+++ b/apps/server/src/sourceControl/AzureDevOpsCli.ts
@@ -94,7 +94,9 @@
     if (
       cause._tag === "VcsProcessSpawnError" &&
       cause.cause instanceof PlatformError.PlatformError &&
-      cause.cause.reason._tag === "NotFound"
+      cause.cause.reason._tag === "NotFound" &&
+      cause.cause.reason.pathOrDescriptor !== context.cwd &&
+      cause.cause.reason.syscall !== "chdir"
     ) {
       return new AzureDevOpsCliUnavailableError(fields);
     }

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 67eff03. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors Azure DevOps CLI error handling by splitting a generic error class into multiple typed error classes and replacing string-based error detection with structured field checks. The changes are internal to error handling with comprehensive test coverage.

No code changes detected at 5252104. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}