[codex] Structure release output failures#3470
Conversation
Co-authored-by: codex <codex@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved Changes are limited to CI/CD release scripts, adding structured error classes for better error reporting when GitHub Actions output operations fail. No production code is affected, and comprehensive tests cover the new error handling paths. You can customize Macroscope's approvability policy. Learn more. |
Summary
Validation
vp test scripts/resolve-nightly-release.test.ts scripts/resolve-previous-release-tag.test.tsvp check(passes with existing repository warnings)vp run typecheckNote
Low Risk
Changes are limited to CI release scripts and error typing; no runtime app, auth, or data-path behavior changes.
Overview
Release helper scripts now surface GITHUB_OUTPUT failures as tagged Schema errors instead of raw Effect failures, while keeping the original cause (and outputPath on append failures) without leaking serialized output into error messages.
resolve-nightly-releaseexportswriteNightlyReleaseOutputand addsNightlyReleaseGitHubOutputConfigError/NightlyReleaseGitHubOutputAppendErroraround config lookup and file append.resolve-previous-release-tagdoes the same forwritePreviousReleaseTagOutputwithPreviousReleaseTagGitHubOutput*errors.listGitTagsmaps stdout vs stderr read failures toread-stdout/read-stderr(replacing a singlecommunicate), and constrains argument counts and stream lengths with non-negative integers.Tests assert cause preservation and that user-facing messages do not echo underlying platform/config text.
Reviewed by Cursor Bugbot for commit 2a7f983. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add structured tagged errors to release output failure paths in nightly and previous-release-tag scripts
writeNightlyReleaseOutputandwritePreviousReleaseTagOutput(previously internalwriteOutput) with structured tagged errors forGITHUB_OUTPUTconfig resolution failures and file append failures, each preserving the underlying cause.NightlyReleaseGitHubOutputConfigError,NightlyReleaseGitHubOutputAppendError,PreviousReleaseTagGitHubOutputConfigError, andPreviousReleaseTagGitHubOutputAppendErrorerror classes.ReleaseTagListProcessErroroperation literals to distinguishread-stdoutvsread-stderrfailures inlistGitTags.Macroscope summarized 2a7f983.