Skip to content

[codex] Structure release output failures#3470

Merged
juliusmarminge merged 1 commit into
mainfrom
codex/structure-release-output-errors
Jun 21, 2026
Merged

[codex] Structure release output failures#3470
juliusmarminge merged 1 commit into
mainfrom
codex/structure-release-output-errors

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Jun 21, 2026

Copy link
Copy Markdown
Member

Summary

  • wrap GITHUB_OUTPUT configuration and append failures with structured Schema errors that preserve their exact causes
  • retain output paths for failed appends without retaining serialized output contents
  • distinguish git stdout and stderr read failures and constrain counts and lengths to non-negative integers

Validation

  • vp test scripts/resolve-nightly-release.test.ts scripts/resolve-previous-release-tag.test.ts
  • vp check (passes with existing repository warnings)
  • vp run typecheck

Note

Low Risk
Changes are limited to CI release scripts and error typing; no runtime app, auth, or data-path behavior changes.

Overview
Release helper scripts now surface GITHUB_OUTPUT failures as tagged Schema errors instead of raw Effect failures, while keeping the original cause (and outputPath on append failures) without leaking serialized output into error messages.

resolve-nightly-release exports writeNightlyReleaseOutput and adds NightlyReleaseGitHubOutputConfigError / NightlyReleaseGitHubOutputAppendError around config lookup and file append.

resolve-previous-release-tag does the same for writePreviousReleaseTagOutput with PreviousReleaseTagGitHubOutput* errors. listGitTags maps stdout vs stderr read failures to read-stdout / read-stderr (replacing a single communicate), and constrains argument counts and stream lengths with non-negative integers.

Tests assert cause preservation and that user-facing messages do not echo underlying platform/config text.

Reviewed by Cursor Bugbot for commit 2a7f983. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add structured tagged errors to release output failure paths in nightly and previous-release-tag scripts

  • Exports writeNightlyReleaseOutput and writePreviousReleaseTagOutput (previously internal writeOutput) with structured tagged errors for GITHUB_OUTPUT config resolution failures and file append failures, each preserving the underlying cause.
  • Adds NightlyReleaseGitHubOutputConfigError, NightlyReleaseGitHubOutputAppendError, PreviousReleaseTagGitHubOutputConfigError, and PreviousReleaseTagGitHubOutputAppendError error classes.
  • Expands ReleaseTagListProcessError operation literals to distinguish read-stdout vs read-stderr failures in listGitTags.
  • Adds tests verifying error types, preserved causes, and output paths for both config and append failure scenarios.

Macroscope summarized 2a7f983.

Co-authored-by: codex <codex@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b2e005ea-583e-45d7-97e7-a3d6ff5ccd6e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/structure-release-output-errors

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Jun 21, 2026
@macroscopeapp

macroscopeapp Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Changes are limited to CI/CD release scripts, adding structured error classes for better error reporting when GitHub Actions output operations fail. No production code is affected, and comprehensive tests cover the new error handling paths.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge merged commit e4a84a3 into main Jun 21, 2026
15 checks passed
@juliusmarminge
juliusmarminge deleted the codex/structure-release-output-errors branch June 21, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant