Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions apps/web/src/components/chat/ChatComposer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ import { ComposerPlanFollowUpBanner } from "./ComposerPlanFollowUpBanner";
import { resolveComposerMenuActiveItemId } from "./composerMenuHighlight";
import { searchSlashCommandItems } from "./composerSlashCommandSearch";
import {
getComposerPromptInjectionState,
getComposerProviderState,
renderProviderTraitsMenuContent,
renderProviderTraitsPicker,
Expand Down Expand Up @@ -791,18 +792,22 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
[selectedProviderEntry],
);

const composerPromptInjectionState = useMemo(
() => getComposerPromptInjectionState(prompt),
[prompt],
);
const composerProviderState = useMemo(
() =>
getComposerProviderState({
provider: selectedProvider,
model: selectedModel,
models: selectedProviderModels,
prompt,
promptInjectionState: composerPromptInjectionState,
modelOptions: composerModelOptions?.[selectedInstanceId],
}),
[
composerModelOptions,
prompt,
composerPromptInjectionState,
selectedInstanceId,
selectedModel,
selectedProvider,
Expand Down
22 changes: 14 additions & 8 deletions apps/web/src/components/chat/composerProviderState.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
type ServerProviderModel,
} from "@t3tools/contracts";
import {
getComposerPromptInjectionState,
getComposerProviderState,
renderProviderTraitsMenuContent,
renderProviderTraitsPicker,
Expand Down Expand Up @@ -61,6 +62,13 @@ const ULTRATHINK_FRAME_CLASSES = {
} as const;

describe("getComposerProviderState", () => {
it("derives a stable prompt injection state for ordinary prompt edits", () => {
expect(getComposerPromptInjectionState("Investigate this failure")).toBe("none");
expect(getComposerPromptInjectionState("Ultrathink:\nInvestigate this failure")).toBe(
"ultrathink",
);
});

it("returns descriptor defaults when no selections are provided", () => {
const state = getComposerProviderState({
provider: PROVIDER,
Expand All @@ -71,7 +79,6 @@ describe("getComposerProviderState", () => {
{ id: "high", label: "High", isDefault: true },
]),
]),
prompt: "",
modelOptions: undefined,
});

Expand All @@ -93,7 +100,6 @@ describe("getComposerProviderState", () => {
]),
booleanDescriptor("fastMode"),
]),
prompt: "",
modelOptions: selections(["effort", "low"], ["fastMode", true]),
});

Expand All @@ -112,7 +118,6 @@ describe("getComposerProviderState", () => {
selectDescriptor("effort", [{ id: "high", label: "High", isDefault: true }]),
booleanDescriptor("fastMode"),
]),
prompt: "",
modelOptions: selections(["effort", "high"], ["fastMode", false]),
});

Expand All @@ -126,7 +131,6 @@ describe("getComposerProviderState", () => {
provider: PROVIDER,
model: MODEL,
models: modelWith([booleanDescriptor("thinking")]),
prompt: "",
modelOptions: selections(["effort", "max"], ["thinking", false]),
});

Expand All @@ -152,7 +156,6 @@ describe("getComposerProviderState", () => {
{ id: "plan", label: "Plan" },
]),
]),
prompt: "",
modelOptions: selections(["agent", "plan"]),
});

Expand All @@ -167,7 +170,6 @@ describe("getComposerProviderState", () => {
provider: PROVIDER,
model: MODEL,
models: modelWith([]),
prompt: "",
modelOptions: selections(["anything", "value"]),
});

Expand All @@ -193,7 +195,9 @@ describe("getComposerProviderState", () => {
["ultrathink"],
),
]),
prompt: "Ultrathink:\nInvestigate this failure",
promptInjectionState: getComposerPromptInjectionState(
"Ultrathink:\nInvestigate this failure",
),
modelOptions: selections(["effort", "medium"]),
});

Expand All @@ -212,7 +216,9 @@ describe("getComposerProviderState", () => {
models: modelWith([
selectDescriptor("effort", [{ id: "high", label: "High", isDefault: true }]),
]),
prompt: "Ultrathink:\nInvestigate this failure",
promptInjectionState: getComposerPromptInjectionState(
"Ultrathink:\nInvestigate this failure",
),
modelOptions: undefined,
});

Expand Down
12 changes: 9 additions & 3 deletions apps/web/src/components/chat/composerProviderState.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@ export type ComposerProviderStateInput = {
provider: ProviderDriverKind;
model: string;
models: ReadonlyArray<ServerProviderModel>;
prompt: string;
promptInjectionState?: ComposerPromptInjectionState;
modelOptions: ReadonlyArray<ProviderOptionSelection> | null | undefined;
};

export type ComposerPromptInjectionState = "none" | "ultrathink";

export type ComposerProviderState = {
provider: ProviderDriverKind;
promptEffort: string | null;
Expand All @@ -46,8 +48,12 @@ type TraitsRenderInput = {
onPromptChange: (prompt: string) => void;
};

export function getComposerPromptInjectionState(prompt: string): ComposerPromptInjectionState {
return isClaudeUltrathinkPrompt(prompt) ? "ultrathink" : "none";
}

export function getComposerProviderState(input: ComposerProviderStateInput): ComposerProviderState {
const { provider, model, models, prompt, modelOptions } = input;
const { provider, model, models, modelOptions, promptInjectionState = "none" } = input;
const caps = getProviderModelCapabilities(models, model, provider);
const descriptors = getProviderOptionDescriptors({ caps, selections: modelOptions });
const primarySelectDescriptor = descriptors.find(
Expand All @@ -58,7 +64,7 @@ export function getComposerProviderState(input: ComposerProviderStateInput): Com
const promptEffort = typeof primaryValue === "string" ? primaryValue : null;
const ultrathinkActive =
(primarySelectDescriptor?.promptInjectedValues?.length ?? 0) > 0 &&
isClaudeUltrathinkPrompt(prompt);
promptInjectionState === "ultrathink";

return {
provider,
Expand Down
2 changes: 0 additions & 2 deletions apps/web/src/modelSelection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,6 @@ export function resolveAppModelSelectionState(
provider,
model,
models: entry.models,
prompt: "",
modelOptions: selectedEntry ? selection.options : undefined,
});

Expand All @@ -321,7 +320,6 @@ export function resolveAppModelSelectionState(
provider,
model,
models: getProviderModels(providers, provider),
prompt: "",
modelOptions: keptSelectedProvider ? selection.options : undefined,
});

Expand Down
Loading