Skip to content

[codex] fix: clarify Cursor CLI setup error#3519

Merged
juliusmarminge merged 4 commits into
pingdotgg:mainfrom
StiensWout:staging/cursor-cli-install-status-copy
Jun 23, 2026
Merged

[codex] fix: clarify Cursor CLI setup error#3519
juliusmarminge merged 4 commits into
pingdotgg:mainfrom
StiensWout:staging/cursor-cli-install-status-copy

Conversation

@StiensWout

@StiensWout StiensWout commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add the Cursor CLI installation docs link to the missing Cursor CLI command status.
  • Clarify Cursor ACP discovery failures with setup guidance while keeping the server-log hint.
  • Keep provider behavior unchanged; this only adjusts status copy and the matching exact-message assertion.

Root cause/Why

Cursor setup failures used terse or stale copy: the command-missing status hard-coded the old command wording without the install docs, and ACP discovery failures only told users to check server logs.

Impact

Users who need to install or enable the Cursor CLI now get the installation URL directly in provider status, and ACP discovery failures explain that Cursor CLI setup may be incomplete before falling back to server-log details.

Validation

  • PATH="$HOME/.vite-plus/bin:$PATH" vp test apps/server/src/provider/Layers/CursorProvider.test.ts
  • PATH="$HOME/.vite-plus/bin:$PATH" vp check
  • PATH="$HOME/.vite-plus/bin:$PATH" vp run typecheck

Refs #2847


Note

Low Risk
User-visible string changes only in Cursor provider status messaging; no auth, data, or discovery logic changes.

Overview
Improves Cursor provider status copy when setup fails, without changing probe or discovery behavior.

When the configured CLI binary cannot be found, the error now names cursorSettings.binaryPath, tells users to install or enable the Cursor CLI and restart T3 Code, and links to the installation docs instead of the old hard-coded agent / PATH wording.

When ACP model discovery fails, the discovery warning is replaced with a longer message that suggests incomplete CLI setup, includes the same docs link, and still points users to server logs for details.

Tests add shared expected strings, a case for the missing-binary message, widen runNode for ChildProcessSpawner, and route existing status/discovery tests through that helper.

Reviewed by Cursor Bugbot for commit 15f4a39. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Clarify Cursor CLI setup errors with path-specific messages and docs links

  • Replaces generic 'agent not installed/on PATH' messages with detailed, path-specific guidance when the Cursor CLI binary is missing, including the configured binary path and a link to installation docs.
  • Adds a CURSOR_ACP_MODEL_DISCOVERY_FAILED_MESSAGE constant with multi-sentence guidance (docs link + prompt to check server logs) shown when ACP model discovery fails.
  • Updates tests to use a runNode helper and adds a new test asserting the detailed error message when the CLI command is missing.

Macroscope summarized 15f4a39.

StiensWout and others added 3 commits June 22, 2026 12:38
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
…atus-copy

[codex] fix: clarify Cursor CLI setup error
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Jun 23, 2026
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5af0f31d-9ba0-4168-a50a-b7e3983151c2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp

macroscopeapp Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Changes are limited to improving error message text to include installation documentation links, plus corresponding test updates. No runtime logic changes beyond string content.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge merged commit 3083d71 into pingdotgg:main Jun 23, 2026
14 checks passed
simonbetton pushed a commit to simonbetton/reviewer that referenced this pull request Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants