[codex] fix: clarify Cursor CLI setup error#3519
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
…atus-copy [codex] fix: clarify Cursor CLI setup error
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Changes are limited to improving error message text to include installation documentation links, plus corresponding test updates. No runtime logic changes beyond string content. You can customize Macroscope's approvability policy. Learn more. |
Co-authored-by: Codex <codex@openai.com>
Summary
Root cause/Why
Cursor setup failures used terse or stale copy: the command-missing status hard-coded the old command wording without the install docs, and ACP discovery failures only told users to check server logs.
Impact
Users who need to install or enable the Cursor CLI now get the installation URL directly in provider status, and ACP discovery failures explain that Cursor CLI setup may be incomplete before falling back to server-log details.
Validation
PATH="$HOME/.vite-plus/bin:$PATH" vp test apps/server/src/provider/Layers/CursorProvider.test.tsPATH="$HOME/.vite-plus/bin:$PATH" vp checkPATH="$HOME/.vite-plus/bin:$PATH" vp run typecheckRefs #2847
Note
Low Risk
User-visible string changes only in Cursor provider status messaging; no auth, data, or discovery logic changes.
Overview
Improves Cursor provider status copy when setup fails, without changing probe or discovery behavior.
When the configured CLI binary cannot be found, the error now names
cursorSettings.binaryPath, tells users to install or enable the Cursor CLI and restart T3 Code, and links to the installation docs instead of the old hard-codedagent/ PATH wording.When ACP model discovery fails, the discovery warning is replaced with a longer message that suggests incomplete CLI setup, includes the same docs link, and still points users to server logs for details.
Tests add shared expected strings, a case for the missing-binary message, widen
runNodeforChildProcessSpawner, and route existing status/discovery tests through that helper.Reviewed by Cursor Bugbot for commit 15f4a39. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Clarify Cursor CLI setup errors with path-specific messages and docs links
CURSOR_ACP_MODEL_DISCOVERY_FAILED_MESSAGEconstant with multi-sentence guidance (docs link + prompt to check server logs) shown when ACP model discovery fails.runNodehelper and adds a new test asserting the detailed error message when the CLI command is missing.Macroscope summarized 15f4a39.