Restore right panel inset when maximized#3555
Conversation
- Apply the collapsed sidebar titlebar inset in maximized desktop mode - Keep the right panel tab bar aligned with native window controls
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved Minor UI styling fix that conditionally applies a padding class when the right panel is maximized. The change is purely visual with no runtime behavior impact. You can customize Macroscope's approvability policy. Learn more. |
- Avoid applying the collapsed sidebar titlebar inset in non-inline layouts - Preserve desktop titlebar spacing while keeping inline maximized tabs aligned
Dismissing prior approval to re-evaluate 2c76fcc
<!--⚠️ READ BEFORE OPENING⚠️ We are not actively accepting contributions right now. You can still open a PR, but please do so knowing there is a high chance we may close it without merging it, or never review it. - Small, focused PRs are strongly preferred. Bug fixes are most likely to be merged. - New features will most likely just annoy us. - 1,000+ line PRs with a bunch of new features will probably get you banned from the repo. --> ## What Changed <!-- Describe the change clearly and keep scope tight. --> ## Why <!-- Explain the problem being solved and why this approach is the right one. --> ## UI Changes <!-- If this PR changes UI, include clear before/after screenshots. If the change involves motion or interaction, include a short video. Delete this section if not applicable. --> ## Checklist - [ ] This PR is small and focused - [ ] I explained what changed and why - [ ] I included before/after screenshots for any UI changes - [ ] I included a video for animation/interaction changes
Summary
Testing
Note
Low Risk
Single conditional CSS class on the right panel top bar; no auth, data, or API changes.
Overview
Restores correct left padding on the right panel tab bar when the inline panel is maximized in the desktop app, so tabs no longer sit under the collapsed-sidebar / native titlebar region.
RightPanelTabsnow applies the sharedCOLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS(already used on the main chat and empty-thread headers) only whenmode === "inline"andmaximizedis true.Reviewed by Cursor Bugbot for commit 2c76fcc. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Restore right panel inset styling when maximized in inline mode
In RightPanelTabs.tsx, the topbar div now conditionally applies
COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASSwhen the panel is in inline mode and maximized, restoring the correct inset appearance under those conditions.Macroscope summarized 2c76fcc.