Skip to content

Restore right panel inset when maximized#3555

Merged
juliusmarminge merged 2 commits into
mainfrom
t3code/right-panel-traffic-fix
Jun 25, 2026
Merged

Restore right panel inset when maximized#3555
juliusmarminge merged 2 commits into
mainfrom
t3code/right-panel-traffic-fix

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Jun 25, 2026

Copy link
Copy Markdown
Member

Summary

  • Restores the right panel tab bar inset when the workspace is maximized.
  • Reuses the collapsed sidebar titlebar inset class so native controls and right-panel traffic no longer overlap.

Testing

  • Not run (PR content only; no code changes made in this step).

Note

Low Risk
Single conditional CSS class on the right panel top bar; no auth, data, or API changes.

Overview
Restores correct left padding on the right panel tab bar when the inline panel is maximized in the desktop app, so tabs no longer sit under the collapsed-sidebar / native titlebar region.

RightPanelTabs now applies the shared COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS (already used on the main chat and empty-thread headers) only when mode === "inline" and maximized is true.

Reviewed by Cursor Bugbot for commit 2c76fcc. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Restore right panel inset styling when maximized in inline mode

In RightPanelTabs.tsx, the topbar div now conditionally applies COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS when the panel is in inline mode and maximized, restoring the correct inset appearance under those conditions.

Macroscope summarized 2c76fcc.

- Apply the collapsed sidebar titlebar inset in maximized desktop mode
- Keep the right panel tab bar aligned with native window controls
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1b788c67-0e5d-4def-8d14-52e97a8606bb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/right-panel-traffic-fix

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Jun 25, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jun 25, 2026
@macroscopeapp

macroscopeapp Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Minor UI styling fix that conditionally applies a padding class when the right panel is maximized. The change is purely visual with no runtime behavior impact.

You can customize Macroscope's approvability policy. Learn more.

- Avoid applying the collapsed sidebar titlebar inset in non-inline layouts
- Preserve desktop titlebar spacing while keeping inline maximized tabs aligned
@macroscopeapp
macroscopeapp Bot dismissed their stale review June 25, 2026 17:03

Dismissing prior approval to re-evaluate 2c76fcc

@juliusmarminge
juliusmarminge enabled auto-merge (squash) June 25, 2026 17:05
@juliusmarminge
juliusmarminge merged commit c2776c2 into main Jun 25, 2026
16 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/right-panel-traffic-fix branch June 25, 2026 17:07
aaditagrawal pushed a commit to aaditagrawal/t3code that referenced this pull request Jun 26, 2026
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Jun 26, 2026
<!--
⚠️ READ BEFORE OPENING ⚠️

We are not actively accepting contributions right now.

You can still open a PR, but please do so knowing there is a high chance
we may close it without merging it, or never review it.

- Small, focused PRs are strongly preferred. Bug fixes are most likely to be merged.
- New features will most likely just annoy us.
- 1,000+ line PRs with a bunch of new features will probably get you banned from the repo.
-->

## What Changed

<!-- Describe the change clearly and keep scope tight. -->

## Why

<!-- Explain the problem being solved and why this approach is the right one. -->

## UI Changes

<!-- If this PR changes UI, include clear before/after screenshots.
     If the change involves motion or interaction, include a short video.
     Delete this section if not applicable. -->

## Checklist

- [ ] This PR is small and focused
- [ ] I explained what changed and why
- [ ] I included before/after screenshots for any UI changes
- [ ] I included a video for animation/interaction changes
chanyeinthaw pushed a commit to sats-lab/pulse that referenced this pull request Jun 28, 2026
simonbetton pushed a commit to simonbetton/reviewer that referenced this pull request Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant