Revert "Add T3 Connect onboarding for mobile and web"

[juliusmarminge]

Reverts #3765

---

Note

Medium Risk
Removes guided post-sign-in setup and changes relay environment discovery timing after sign-in, which may leave cloud lists empty until settings triggers a refresh; core linking UI remains in Connections/Environments.

Overview
This reverts the T3 Connect onboarding work from #3765: post-sign-in wizards, opt-out persistence, and the shared cloud-environment list components are removed from mobile and web.

Mobile drops the ConnectOnboarding form sheet, navigation hook, request atom, and sign-in trigger in CloudAuthProvider. T3 Cloud environment rows are inlined into SettingsEnvironmentsRouteScreen (replacing CloudEnvironmentRows). User-facing copy shifts from “T3 Connect” to “T3 Cloud” in several connection/settings strings, and connectOnboardingOptOutAccounts is removed from preferences.

Web removes ConnectOnboardingDialog from the root layout plus deleted modules (useCloudLinkController, CloudEnvironmentConnectList, shared itemRows). Connections settings now owns primary-environment link reconciliation and remote “Connect” rows inline (logic formerly in the hook/list components).

client-runtime relay discovery only re-fetches on credentials-changed if the user has already triggered a refresh once, and signed-out/auth failures are surfaced as errors again instead of a silent empty list; related discovery tests are removed.

^{Reviewed by Cursor Bugbot for commit a2f86c8. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Revert T3 Connect onboarding flow and rename branding to T3 Cloud

• Removes the ConnectOnboarding screen, dialog, and navigation hooks from both mobile (Stack.tsx) and web (__root.tsx), so users are no longer shown an onboarding sheet after sign-in.
• Replaces CloudEnvironmentRows with new in-file components (ConfiguredCloudEnvironmentRows, CloudEnvironmentRowShell, etc.) in mobile settings and web ConnectionsSettings, adding richer status display, error handling with trace ID copy, and connect/disconnect interactions.
• Updates RelayEnvironmentDiscovery to only auto-refresh on credentials-changed if a prior refresh has already occurred, and to surface authentication-blocked errors in state rather than suppressing them.
• Renames all user-facing and error message strings from 'T3 Connect' to 'T3 Cloud' across mobile and web.
• Removes connectOnboardingOptOutAccounts from the Preferences interface and storage loading logic.

📊 Macroscope summarized a2f86c8. 13 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 19fdb548-ee6a-413f-be46-8e57dd25792d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert-3765-t3code/connect-onboarding-wizard

---

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

^{Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.}

^{Reviewed by Cursor Bugbot for commit a2f86c8. Configure here.}

[cursor]

False empty cloud after sign-in

Medium Severity

After an in-session sign-in, credentials-changed clears relay discovery but skips refresh until hasRefreshed is true. Mobile environment settings then show “No additional linked cloud environments” even though relay was never queried, so published devices can look absent until the user taps refresh.

Additional Locations (1)

• apps/mobile/src/features/settings/SettingsEnvironmentsRouteScreen.tsx#L218-L224

 

^{Reviewed by Cursor Bugbot for commit a2f86c8. Configure here.}

[cursor]

Stale auth error after sign-in

Medium Severity

After a prior relay refresh, sign-out triggers another refresh that fails without credentials. The handler now always stores that failure in discovery.error instead of treating signed-out refresh as idle. Mobile can show “Could not load T3 Cloud environments” while Clerk already reports the user signed in, until activateCloudRelayAccount runs.

Additional Locations (1)

• packages/client-runtime/src/relay/discovery.ts#L306-L318

 

^{Reviewed by Cursor Bugbot for commit a2f86c8. Configure here.}

[macroscopeapp]

🟡 Medium relay/discovery.ts:316

The credentials-changed wakeup now resets state to the empty list but then skips refresh when hasRefreshed is false. On a cold start with an already signed-in user, hasRefreshed starts as false and is only set to true inside refresh itself — so this guard creates a chicken-and-egg deadlock. The wakeup wipes state clean and never repopulates it, so any UI reading state (e.g., SettingsEnvironmentsRouteScreen) shows an empty list with "No additional linked cloud environments" even when linked environments actually exist, until the user manually taps refresh.

The previous code always refreshed on this wakeup (with a comment explaining it fires on session activation / cold start), and the refresh flow already handles sign-out by settling back to the empty state. Consider restoring the unconditional refresh here, or seeding hasRefreshed so the proactive refresh isn't blocked on first run.

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file @packages/client-runtime/src/relay/discovery.ts around line 316:

The `credentials-changed` wakeup now resets `state` to the empty list but then skips `refresh` when `hasRefreshed` is `false`. On a cold start with an already signed-in user, `hasRefreshed` starts as `false` and is only set to `true` inside `refresh` itself — so this guard creates a chicken-and-egg deadlock. The wakeup wipes `state` clean and never repopulates it, so any UI reading `state` (e.g., `SettingsEnvironmentsRouteScreen`) shows an empty list with "No additional linked cloud environments" even when linked environments actually exist, until the user manually taps refresh.

The previous code always refreshed on this wakeup (with a comment explaining it fires on session activation / cold start), and the `refresh` flow already handles sign-out by settling back to the empty state. Consider restoring the unconditional `refresh` here, or seeding `hasRefreshed` so the proactive refresh isn't blocked on first run.

[macroscopeapp]

Approvability

Verdict: Needs human review

1 blocking correctness issue found. Unresolved review comments identify potential bugs in the relay discovery logic changes: the conditional refresh guard may cause empty cloud environment lists after sign-in, and sign-out error handling changed in ways that could show stale errors. These behavioral changes warrant human review.

^{You can customize Macroscope's approvability policy. Learn more.}