Re-encode production splash PNG for GitHub preview#3782
Closed
juliusmarminge wants to merge 1 commit into
Closed
Conversation
The black-ios-1024 artwork is correct, but its Skia ICC profile makes GitHub PR/file previews fail with Invalid image source. Re-encode to a plain IHDR/IDAT/IEND RGBA PNG with identical pixels. Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The black-ios-1024 artwork merged in #3780 is correct, but its Skia ICC profile makes GitHub PR and file previews fail with Invalid image source.
Re-encode splash-icon-prod.png to a plain IHDR/IDAT/IEND RGBA PNG with identical pixels so GitHub can render it. Artwork unchanged.
Note
Re-encode production splash PNG for GitHub preview
Re-encodes splash-icon-prod.png so the image renders correctly in GitHub's preview. No functional change to the app.
Macroscope summarized d3a7e59.