Skip to content

Fix sending messages during active turns#3919

Merged
juliusmarminge merged 4 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/fix-send-during-agent-response
Jul 18, 2026
Merged

Fix sending messages during active turns#3919
juliusmarminge merged 4 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/fix-send-during-agent-response

Conversation

@jakeleventhal

@jakeleventhal jakeleventhal commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

What changed

  • track the latest projected user message in the local dispatch snapshot
  • acknowledge sends that add a steering message to an already-running turn
  • add regression coverage for steering without a new turn or timestamp change

Why

Messages sent while an agent was already working remain on the current turn. The composer only recognized server acknowledgment when turn metadata changed, so its local sending state could remain stuck until the thread was remounted by navigating away and back.

This change also treats the newly projected user message as acknowledgment, allowing subsequent steering messages without thread navigation.

Validation

  • pnpm exec vp test apps/web/src/components/ChatView.logic.test.ts
  • pnpm exec vp check
  • pnpm exec vp run typecheck

Note

Fix message sending during active turns by recognizing steering messages as server acknowledgment

  • hasServerAcknowledgedLocalDispatch now returns true during a running turn when the latest user message ID changes, treating a projected steering message as server acknowledgment
  • LocalDispatchSnapshot gains a latestUserMessageId field, captured via findLast over messages with role === 'user' at snapshot creation time
  • ChatView.useLocalDispatchState passes the current latestUserMessageId into the acknowledgment check, clearing activeLocalDispatch and unblocking isSendBusy sooner when a steering message appears

Macroscope summarized d84bb40.


Note

Low Risk
Targeted chat UI state logic with unit tests; no auth, data, or API surface changes.

Overview
Fixes the composer staying in a Sending / busy state when users send steering messages while a turn is already running.

Local dispatch acknowledgment now records the latest user message id in LocalDispatchSnapshot and passes the live id from useLocalDispatchState. During the running phase, hasServerAcknowledgedLocalDispatch treats a change in that id as server acknowledgment—even when turn metadata is unchanged—so activeLocalDispatch clears and isSendBusy recovers without navigating away.

Regression coverage adds the steering-on-current-turn case in ChatView.logic.test.ts.

Reviewed by Cursor Bugbot for commit d84bb40. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 503bd64d-c58c-4b8c-80ea-3ce9fbe5bf39

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Jul 12, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 12, 2026 18:45
Comment thread apps/web/src/components/ChatView.tsx

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9361c84. Configure here.

Comment thread apps/web/src/components/ChatView.tsx Outdated
@macroscopeapp

macroscopeapp Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Straightforward bug fix that adds tracking for the latest user message ID to properly acknowledge steering messages during active turns. The change is self-contained with clear intent, good documentation, and comprehensive test coverage.

You can customize Macroscope's approvability policy. Learn more.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9361c84e3b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/ChatView.tsx Outdated
@QarthO

QarthO commented Jul 16, 2026

Copy link
Copy Markdown

For those who also come across this issue/waiting for it to be merged,

a current workaround you can do is swap to a different thread, then come back to the broken thread and you're able to send messages again

@juliusmarminge
juliusmarminge merged commit d8b12ae into pingdotgg:main Jul 18, 2026
14 checks passed
adamfgr pushed a commit to agriffiths-bots/t3code that referenced this pull request Jul 19, 2026
* Fix dropped events during initial thread snapshot (pingdotgg#4079)

* [codex] fix mobile composer Enter behavior (pingdotgg#3930)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>

* feat: draft hero landing on the index route (pingdotgg#4055)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>

* feat: file explorer mention actions and zoom-aware context menus (pingdotgg#4054)

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>

* fix(web): avoid duplicate mention text on paste

Co-authored-by: codex <codex@users.noreply.github.com>

* fix(mobile): restore iOS home screen branding (pingdotgg#4025)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

* perf(client): defer active thread cache writes (pingdotgg#4006)

* Default diffs to working changes (pingdotgg#3974)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

* Add Grok to marketing site provider list (pingdotgg#3484)

* Fix reopening existing Diff tab (pingdotgg#3973)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

* Fix sending messages during active turns (pingdotgg#3919)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

* [codex] Route OpenCode missing-session errors through Effect (pingdotgg#3608)

Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>

* [fix/feat:ui] Show default option badge (pingdotgg#3232)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

* [fix/feat:ui] Preserve open-in editor brand colors (pingdotgg#3225)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

* fix(web): handle macOS Home and End in composer (pingdotgg#2508)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

* Allow failed remote environments to be removed (pingdotgg#4084)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

* [codex] canonicalize client timestamps (pingdotgg#4112)

* [fix/feat:ui] Make selected menu checks blue (pingdotgg#3234)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>

* fix(desktop): Validate WSL node version against engine range after probe success (pingdotgg#3621)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

* Refresh splash screen and favicon branding (pingdotgg#4120)

* Add terminal selection copy action (pingdotgg#2904)

* fix(sync): reconcile upstream changes with fork-local behaviour

Two merge-introduced incompatibilities from the 20260719 upstream sync:

- Normalizer: upstream's client-timestamp canonicalization (da3c203)
  rewrote bootstrap.createThread.createdAt, which BootstrapTurnStartDispatcher
  uses to fingerprint a replayed bootstrap turn against the thread it already
  created. Every retry would miss that check and create a duplicate thread.
  Keep the client's bootstrap timestamp as the stable identity; the turn-level
  createdAt is still canonicalized.

- ThreadTerminalDrawer: upstream's terminal selection copy action (1735e27)
  passed a Terminal to writeSystemMessage, which this fork narrowed to accept
  a TerminalWriteQueue. Use terminalWriterRef, matching the other call sites.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Co-authored-by: Ishan <ishansachu1@gmail.com>
Co-authored-by: Maxwell Young <maxtheyoung@gmail.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Yordis Prieto <yordis.prieto@gmail.com>
Co-authored-by: Alex <me@pixp.cc>
Co-authored-by: Chris Michael Guzman <67719167+Chrrxs@users.noreply.github.com>
Co-authored-by: Jake Leventhal <jakeleventhal@me.com>
Co-authored-by: Aditya Mer <101453576+Aditya190803@users.noreply.github.com>
Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: ss <69873514+sandersonstabo@users.noreply.github.com>
Co-authored-by: Guilherme Vieira <46866023+GuilhermeVieiraDev@users.noreply.github.com>
Co-authored-by: Noah Zepner <noah@zepner.dev>
Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com>
Co-authored-by: Taras <Taras.Fomin@gmail.com>
Co-authored-by: wizzoapp[bot] <254688279+wizzoapp[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
bcotrim pushed a commit to bcotrim/mognet that referenced this pull request Jul 19, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 20, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit d8b12ae)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 20, 2026
…ngdotgg#4055pingdotgg#4164) (#175)

* feat: draft hero landing on the index route (pingdotgg#4055)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
(cherry picked from commit 1bd2fa2)

* feat: file explorer mention actions and zoom-aware context menus (pingdotgg#4054)

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit 4cfec8c)

* fix(web): avoid duplicate mention text on paste

Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit 2318e00)

* Default diffs to working changes (pingdotgg#3974)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit 38e0bb0)

* Fix reopening existing Diff tab (pingdotgg#3973)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit 31caa56)

* Fix sending messages during active turns (pingdotgg#3919)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit d8b12ae)

* [fix/feat:ui] Show default option badge (pingdotgg#3232)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit c0e161a)

* [fix/feat:ui] Preserve open-in editor brand colors (pingdotgg#3225)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit e63403f)

* fix(web): handle macOS Home and End in composer (pingdotgg#2508)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit b859a57)

* Allow failed remote environments to be removed (pingdotgg#4084)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit 0506508)

* [fix/feat:ui] Make selected menu checks blue (pingdotgg#3234)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit 5c66110)

* Add terminal selection copy action (pingdotgg#2904)

(cherry picked from commit 1735e27)

* fix(web): improve dev sidebar backdrop contrast & remove version pills (pingdotgg#4166)

(cherry picked from commit b511227)

* Fix draft banner stack overlap (pingdotgg#4164)

Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit 7e1a0d5)

---------

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Co-authored-by: Yordis Prieto <yordis.prieto@gmail.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Jake Leventhal <jakeleventhal@me.com>
Co-authored-by: ss <69873514+sandersonstabo@users.noreply.github.com>
Co-authored-by: Guilherme Vieira <46866023+GuilhermeVieiraDev@users.noreply.github.com>
Co-authored-by: Noah Zepner <noah@zepner.dev>
Co-authored-by: Taras <Taras.Fomin@gmail.com>
Co-authored-by: maria <maria@kuuro.net>
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 20, 2026
…ngdotgg#4055pingdotgg#4164) (#175) (#177)

* feat: draft hero landing on the index route (pingdotgg#4055)




(cherry picked from commit 1bd2fa2)

* feat: file explorer mention actions and zoom-aware context menus (pingdotgg#4054)



(cherry picked from commit 4cfec8c)

* fix(web): avoid duplicate mention text on paste


(cherry picked from commit 2318e00)

* Default diffs to working changes (pingdotgg#3974)


(cherry picked from commit 38e0bb0)

* Fix reopening existing Diff tab (pingdotgg#3973)


(cherry picked from commit 31caa56)

* Fix sending messages during active turns (pingdotgg#3919)


(cherry picked from commit d8b12ae)

* [fix/feat:ui] Show default option badge (pingdotgg#3232)


(cherry picked from commit c0e161a)

* [fix/feat:ui] Preserve open-in editor brand colors (pingdotgg#3225)


(cherry picked from commit e63403f)

* fix(web): handle macOS Home and End in composer (pingdotgg#2508)


(cherry picked from commit b859a57)

* Allow failed remote environments to be removed (pingdotgg#4084)


(cherry picked from commit 0506508)

* [fix/feat:ui] Make selected menu checks blue (pingdotgg#3234)



(cherry picked from commit 5c66110)

* Add terminal selection copy action (pingdotgg#2904)

(cherry picked from commit 1735e27)

* fix(web): improve dev sidebar backdrop contrast & remove version pills (pingdotgg#4166)

(cherry picked from commit b511227)

* Fix draft banner stack overlap (pingdotgg#4164)


(cherry picked from commit 7e1a0d5)

---------

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Co-authored-by: Yordis Prieto <yordis.prieto@gmail.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Jake Leventhal <jakeleventhal@me.com>
Co-authored-by: ss <69873514+sandersonstabo@users.noreply.github.com>
Co-authored-by: Guilherme Vieira <46866023+GuilhermeVieiraDev@users.noreply.github.com>
Co-authored-by: Noah Zepner <noah@zepner.dev>
Co-authored-by: Taras <Taras.Fomin@gmail.com>
Co-authored-by: maria <maria@kuuro.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants