Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import {
EventId,
ProviderDriverKind,
RuntimeRequestId,
ThreadId,
type ProviderRuntimeEvent,
} from "@t3tools/contracts";
import { describe, expect, it } from "vite-plus/test";

import { runtimeEventToActivities } from "./ProviderRuntimeIngestion.ts";

describe("runtimeEventToActivities approval details", () => {
it("preserves complete multiline command details", () => {
const detail = `bun run release -- ${"long-argument ".repeat(20)}\nsecond line`;
const event = {
type: "request.opened",
eventId: EventId.make("evt-request-opened"),
provider: ProviderDriverKind.make("codex"),
createdAt: "2026-07-18T00:00:00.000Z",
threadId: ThreadId.make("thread-1"),
requestId: RuntimeRequestId.make("approval-1"),
payload: {
requestType: "command_execution_approval",
detail,
},
} satisfies ProviderRuntimeEvent;

const [activity] = runtimeEventToActivities(event);

expect(activity?.kind).toBe("approval.requested");
expect((activity?.payload as Record<string, unknown> | undefined)?.detail).toBe(detail);
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ function requestKindFromCanonicalRequestType(
}
}

function runtimeEventToActivities(
export function runtimeEventToActivities(
event: ProviderRuntimeEvent,
): ReadonlyArray<OrchestrationThreadActivity> {
const maybeSequence = (() => {
Expand Down Expand Up @@ -295,7 +295,7 @@ function runtimeEventToActivities(
requestId: toApprovalRequestId(event.requestId),
...(requestKind ? { requestKind } : {}),
requestType: event.payload.requestType,
...(event.payload.detail ? { detail: truncateDetail(event.payload.detail) } : {}),
...(event.payload.detail ? { detail: event.payload.detail } : {}),
},
turnId: toTurnId(event.turnId) ?? null,
...maybeSequence,
Expand Down
28 changes: 28 additions & 0 deletions apps/web/src/components/chat/ComposerPendingApprovalPanel.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { ApprovalRequestId } from "@t3tools/contracts";
import { renderToStaticMarkup } from "react-dom/server";
import { describe, expect, it } from "vite-plus/test";

import { ComposerPendingApprovalPanel } from "./ComposerPendingApprovalPanel";

describe("ComposerPendingApprovalPanel", () => {
it("renders complete multiline command details without hover or truncation", () => {
const detail = `bun run release -- ${"long-argument ".repeat(20)}\nsecond line`;
const markup = renderToStaticMarkup(
<ComposerPendingApprovalPanel
approval={{
requestId: ApprovalRequestId.make("approval-1"),
requestKind: "command",
createdAt: "2026-07-18T00:00:00.000Z",
detail,
}}
pendingCount={1}
/>,
);

expect(markup).toContain('data-approval-detail="complete"');
expect(markup).toContain('aria-label="Command"');
expect(markup).toContain(detail);
expect(markup).not.toContain("truncate");
expect(markup).not.toContain("line-clamp");
});
});
18 changes: 18 additions & 0 deletions apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ export const ComposerPendingApprovalPanel = memo(function ComposerPendingApprova
: approval.requestKind === "file-read"
? "File-read approval requested"
: "File-change approval requested";
const detailLabel =
approval.requestKind === "command"
? "Command"
: approval.requestKind === "file-read"
? "File to read"
: "File change";

return (
<div className="px-4 py-3.5 sm:px-5 sm:py-4">
Expand All @@ -26,6 +32,18 @@ export const ComposerPendingApprovalPanel = memo(function ComposerPendingApprova
<span className="text-xs text-muted-foreground">1/{pendingCount}</span>
) : null}
</div>
{approval.detail ? (
<div className="mt-3 rounded-lg border border-border/65 bg-background/70 p-3">
<p className="text-xs font-medium text-muted-foreground">{detailLabel}</p>
<pre
aria-label={detailLabel}
className="mt-2 max-h-40 overflow-auto whitespace-pre-wrap break-words font-mono text-xs leading-relaxed text-foreground"
data-approval-detail="complete"
>
{approval.detail}
</pre>
</div>
) : null}
</div>
);
});
Loading