Skip to content

Reduce background Git ref and port polling#4187

Open
Quicksaver wants to merge 22 commits into
pingdotgg:mainfrom
Quicksaver:fix/reduce-background-git-ref-port-polling
Open

Reduce background Git ref and port polling#4187
Quicksaver wants to merge 22 commits into
pingdotgg:mainfrom
Quicksaver:fix/reduce-background-git-ref-port-polling

Conversation

@Quicksaver

@Quicksaver Quicksaver commented Jul 20, 2026

Copy link
Copy Markdown

Summary

Reduce persistent background work from Git ref enumeration and preview port discovery while preserving freshness when users interact with either surface.

What Changed

  • Revalidate only the first Git-ref page every 20 seconds instead of polling every retained page every five seconds
  • Load cursor pages once per connected generation and expire inactive ref atoms after 30 seconds
  • Refresh local and remote refs immediately when the composer branch or Diff comparison menu opens
  • Replay the latest preview-discovery snapshot instead of running a duplicate subscription scan
  • Serialize snapshot replay with concurrent broadcasts so subscribers cannot regress to stale results
  • Scan immediately when managed terminal process sets change and ignore unchanged registrations or redundant removals
  • Run the broad port-discovery safety net every 20 seconds while idle and every 10 seconds when a listener is known

Why

During extended use, T3 Code's resident memory climbed past 6 GB even while idle, while the renderer sustained roughly 10% CPU and the machine became noticeably warm around the CPU and GPU clusters. That pattern indicated that background work was continuing without user interaction and could compound renderer and resource pressure over long sessions.

Diagnostics identified two repeatable sources of idle churn: every retained Git-ref query, including each loaded pagination page, owned its own five-second listRefs revalidation loop, while preview discovery launched a broad lsof scan every three seconds. Preview subscription initialization could also scan twice, and unchanged terminal process registrations caused redundant probes. The new schedules reduce that steady subprocess load while immediate menu refreshes, terminal-process-triggered scans, and adaptive safety-net polling preserve freshness at interaction time.

Validation

  • Port scanner focused suite passed with 6 tests, including concurrent replay ordering
  • Targeted server and client-runtime type checks passed
  • Isolated authenticated web verification loaded local, worktree, and remote refs when the branch selector opened
  • git diff --check passed

Proof

No standalone proof artifacts were captured; the isolated browser verification is summarized above.


Note

Medium Risk
Touches live preview discovery and ref freshness semantics across client and server; behavior is well tested but stale refs could linger up to 20s unless the user opens a menu.

Overview
Cuts idle background work from Git ref lists and preview port discovery while keeping data fresh when users open branch or comparison menus.

Git refs (client-runtime): First-page ref revalidation moves from 5s to 20s; paginated cursor pages no longer tick on an interval (one-shot per connection generation). Ref list atoms use a 30s idle TTL instead of five minutes. Tests assert the new 20s interval.

UI: refreshVcsRefsOnMenuOpen centralizes open-only ref refresh for the composer branch selector and Diff base-ref combobox (Diff refreshes local and remote); closing menus only clears search query, not refs.

Port discovery (server): Replaces a fixed 3s lsof poll with 20s idle / 10s when a listener is already known. Subscribers get the latest snapshot under a semaphore (no duplicate scan in ws.ts); terminal PID updates scan immediately but skip no-op re-registrations. New PortScanner tests cover replay, ordering, and deduped registrations.

Reviewed by Cursor Bugbot for commit bb1446c. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Reduce background Git ref and port polling frequency

  • Increases the VCS ref revalidation interval from 5s to 20s and reduces the idle cache TTL to 30s; only the first page of refs is periodically revalidated while paginated pages are one-shot.
  • Replaces the fixed 3s PortDiscovery poll interval with adaptive intervals: 10s when listeners are active and servers are known, 20s otherwise.
  • New subscribers to PortDiscovery now receive an immediate replay of the latest snapshot instead of requiring an explicit scan in the WS handler.
  • Adds a notificationLock semaphore to serialize snapshot broadcasts with subscription replays, preventing stale interleaving.
  • Extracts refreshVcsRefsOnMenuOpen to centralize open-only ref refresh behavior across BranchToolbarBranchSelector and DiffPanel; closing a menu no longer triggers a refresh.

Macroscope summarized bb1446c.

- Poll first ref pages every 20 seconds and refresh menus on open
- Avoid duplicate port scans and adapt lsof polling to activity
- Document the retained freshness guarantees
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fdaec52a-bfbd-419a-923c-177259d6e8ff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Jul 20, 2026
Comment thread apps/server/src/preview/PortScanner.ts
@macroscopeapp

macroscopeapp Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Performance optimization that reduces polling intervals for Git refs and port scanning, with optimizations to avoid redundant work. Changes are well-tested, clearly documented, and limited to timing adjustments without introducing new features or behavioral complexity.

You can customize Macroscope's approvability policy. Learn more.

- Order subscription replay with concurrent snapshot broadcasts
- Cover replay ordering with a focused concurrent regression test
- Document the preview notification ordering guarantee

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bb1446c. Configure here.

listeners: new Set([...state.listeners, listener]),
},
]).pipe(Effect.tap(listener)),
),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaked listener breaks port broadcasts

Medium Severity

PortDiscovery.subscribe adds the listener to scanner state and then replays the snapshot in the same acquire step. If that replay effect fails, Effect.acquireRelease skips release, so the listener stays registered even though the subscription never completed. Later broadcast runs every listener with Effect.forEach, so one failing replay listener can abort the whole broadcast and stop live port updates for other subscribers.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit bb1446c. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant