fix(web): use message-square icon for settled icon-less project threads in sidebar v2#4279
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9a2a1bb. Configure here.
ApprovabilityVerdict: Approved This PR adds an optional fallback icon prop to the ProjectFavicon component and uses it to show a message-square icon instead of a folder icon in the sidebar. The change is purely cosmetic with no runtime behavior impact. You can customize Macroscope's approvability policy. Learn more. |
9a2a1bb to
b28b3bb
Compare

What Changed
ProjectFavicongained an optionalfallbackIconprop (defaults toFolderIcon)MessageSquareIconas the fallbackFolderIconbeside the project name stays correctWhy
Settled threads show the project favicon beside the thread title. When a project has no favicon,
FolderIconwas shown, which is misleading next to a thread name (it implies the thread is a folder).MessageSquareIconwas already used elsewhere in the codebase for thread-related commands, so is a natural fit and visually matches the small icon size.UI Changes
Before:

After:

Checklist
Note
Low Risk
Small presentational change with a backward-compatible optional prop; no auth, data, or API impact.
Overview
ProjectFaviconnow accepts an optionalfallbackIconprop (still defaults toFolderIcon) and uses it whenever there is no favicon URL, including while an image is loading or after load errors.In sidebar v2, slim (settled) thread rows pass
MessageSquareIconas that fallback so icon-less projects show a chat glyph next to the thread title instead of a folder. Card rows and otherProjectFaviconcall sites are unchanged and keep the folder fallback beside project names.Reviewed by Cursor Bugbot for commit 154821a. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Use message-square icon for icon-less project threads in sidebar v2
Adds a
fallbackIconprop toProjectFavicon,ProjectFaviconFallback, andProjectFaviconImagein ProjectFavicon.tsx so callers can supply a custom icon instead of the defaultFolderIcon. In SidebarV2.tsx, thread rows now passMessageSquareIconas the fallback, so a chat bubble appears when a thread has no favicon rather than a folder.Macroscope summarized 154821a.