Skip to content

fix(web): use message-square icon for settled icon-less project threads in sidebar v2#4279

Merged
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
UtkarshUsername:fix/sidebar-v2-settled-thread-icon
Jul 22, 2026
Merged

fix(web): use message-square icon for settled icon-less project threads in sidebar v2#4279
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
UtkarshUsername:fix/sidebar-v2-settled-thread-icon

Conversation

@UtkarshUsername

@UtkarshUsername UtkarshUsername commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • ProjectFavicon gained an optional fallbackIcon prop (defaults to FolderIcon)
  • Settled threads (slim rows) in sidebar v2 now pass MessageSquareIcon as the fallback
  • Card variant (active threads) unchanged. FolderIcon beside the project name stays correct

Why

Settled threads show the project favicon beside the thread title. When a project has no favicon, FolderIcon was shown, which is misleading next to a thread name (it implies the thread is a folder). MessageSquareIcon was already used elsewhere in the codebase for thread-related commands, so is a natural fit and visually matches the small icon size.

UI Changes

Before:
image

After:
image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Small presentational change with a backward-compatible optional prop; no auth, data, or API impact.

Overview
ProjectFavicon now accepts an optional fallbackIcon prop (still defaults to FolderIcon) and uses it whenever there is no favicon URL, including while an image is loading or after load errors.

In sidebar v2, slim (settled) thread rows pass MessageSquareIcon as that fallback so icon-less projects show a chat glyph next to the thread title instead of a folder. Card rows and other ProjectFavicon call sites are unchanged and keep the folder fallback beside project names.

Reviewed by Cursor Bugbot for commit 154821a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Use message-square icon for icon-less project threads in sidebar v2

Adds a fallbackIcon prop to ProjectFavicon, ProjectFaviconFallback, and ProjectFaviconImage in ProjectFavicon.tsx so callers can supply a custom icon instead of the default FolderIcon. In SidebarV2.tsx, thread rows now pass MessageSquareIcon as the fallback, so a chat bubble appears when a thread has no favicon rather than a folder.

Macroscope summarized 154821a.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3356d028-82a2-4894-866d-3a7c88338667

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Jul 22, 2026
Comment thread apps/web/src/components/ProjectFavicon.tsx Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9a2a1bb. Configure here.

Comment thread apps/web/src/components/ProjectFavicon.tsx
@macroscopeapp

macroscopeapp Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

This PR adds an optional fallback icon prop to the ProjectFavicon component and uses it to show a message-square icon instead of a folder icon in the sidebar. The change is purely cosmetic with no runtime behavior impact.

You can customize Macroscope's approvability policy. Learn more.

@UtkarshUsername
UtkarshUsername force-pushed the fix/sidebar-v2-settled-thread-icon branch from 9a2a1bb to b28b3bb Compare July 22, 2026 14:09
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Jul 22, 2026
@juliusmarminge
juliusmarminge merged commit 020179c into pingdotgg:main Jul 22, 2026
14 checks passed
UNN-Devotek pushed a commit to unn-corp/t3code that referenced this pull request Jul 23, 2026
AnanduB13 pushed a commit to AnanduB13/t3code that referenced this pull request Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants