fix(web): warn before silent Windows updates#4350
Conversation
- Explain that Windows installation may keep T3 Code closed for several minutes. - Tell users that no installer window may appear and the app will reopen automatically. - Apply the warning to every desktop update entry point and add focused platform coverage.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved This PR adds Windows-specific warning copy to the update confirmation dialog, informing users that silent updates may take several minutes. The change is purely informational text with no impact on update behavior. Unit tests cover the new functionality. You can customize Macroscope's approvability policy. Learn more. |
|
Do you think you could add the same to the installation part? and also for switching between branch tracking? |
(cherry picked from commit b41e89e)
(cherry picked from commit b41e89e)
(cherry picked from commit b41e89e)
(cherry picked from commit b41e89e)
(cherry picked from commit b41e89e)
(cherry picked from commit b41e89e)
(cherry picked from commit b41e89e)
(cherry picked from commit b41e89e)
(cherry picked from commit b41e89e)
(cherry picked from commit b41e89e)
(cherry picked from commit b41e89e)
(cherry picked from commit b41e89e)
(cherry picked from commit b41e89e)
(cherry picked from commit b41e89e)
(cherry picked from commit b41e89e)
(cherry picked from commit b41e89e)
…ingdotgg#4350) (#185) * feat: add "Auto" runtime mode — AI-reviewed approvals for Codex and Claude (pingdotgg#4272) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit fbd7742) * Add shared t3.json project configuration support (pingdotgg#4317) (cherry picked from commit 1c9a6de) * Restore light-mode surfaces and refine dialog styling - Restore light-mode glass, dialog, dropdown, and composer colors - Refine provider wizard, changed-file cards, sidebar controls, and buttons - Update wizard step tests for the new list structure (cherry picked from commit e51538b) * Unify dialog glass and fix composer overlays (pingdotgg#4365) Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 4d83436) * fix(web): warn before silent Windows updates (pingdotgg#4350) (cherry picked from commit b41e89e) * chore(sync): retrigger CI for #185 after retarget to main Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com> * fix(sync): preserve Droid medium-access with Auto runtime mode Keep fork-only medium-access in RuntimeMode alongside upstream Auto so presentation maps and Droid autonomy mapping typecheck and behave. Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com> --------- Co-authored-by: Theo Browne <me@t3.gg> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com> Co-authored-by: Yukun Shan <92423096+nateEc@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Closes #4328
Summary
Verification
vp test run apps/web/src/components/desktopUpdate.logic.test.ts(26 passed)vp run --filter @t3tools/web typechecktest-t3-app: paired an isolated environment, launched the app, and opened the Settings panel successfullyThe platform-specific copy is covered with explicit Win32 and MacIntel cases because the isolated web runner is not an Electron/Windows host.
Note
Low Risk
Copy-only change to install confirmation strings with platform gating; no updater or install logic modified.
Overview
Windows users see extra copy in the desktop install update confirmation dialog explaining that T3 Code may stay closed for several minutes during a silent install, that no installer window may appear, and that the app will reopen when finished.
getDesktopUpdateInstallConfirmationMessagegains an optional platform argument (default empty) and usesisWindowsPlatformto append that paragraph only on Windows. Sidebar, SidebarUpdatePill, and About settings now passnavigator.platformso all install paths share the same message.Unit tests cover Win32 (warning present) vs MacIntel (warning absent).
Reviewed by Cursor Bugbot for commit 4ffba05. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Warn Windows users before silent desktop updates in confirmation dialogs
Adds a Windows-specific warning to the update installation confirmation dialog shown in the sidebar and settings.
getDesktopUpdateInstallConfirmationMessagein desktopUpdate.logic.ts now accepts an optionalplatformparameter and appends the warning whenisWindowsPlatform(platform)is true. Callers in Sidebar.tsx, SidebarUpdatePill.tsx, and SettingsPanels.tsx passnavigator.platformas the second argument.Macroscope summarized 4ffba05.