Skip to content

Fix logical project grouping labels on mobile#4391

Merged
juliusmarminge merged 3 commits into
mainfrom
codex/fix-mobile-project-grouping
Jul 23, 2026
Merged

Fix logical project grouping labels on mobile#4391
juliusmarminge merged 3 commits into
mainfrom
codex/fix-mobile-project-grouping

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary

  • build the phone project filter from logical project scopes instead of raw project records
  • show logical repository labels on Thread List V2 rows on phone and tablet
  • use repository labels consistently for singleton repository scopes

Verification

  • vp test run apps/mobile/src/features/home/homeThreadList.test.ts
  • targeted vp lint --report-unused-disable-directives on changed files
  • vp run --filter @t3tools/mobile typecheck
  • vp run lint:mobile
  • iOS Simulator against disposable state with two physical projects from one repository

Note

Low Risk
UI labeling and client-side list filtering only; no auth, API, or persistence changes.

Overview
Mobile home and sidebar thread lists now use logical project scope titles (e.g. repository display names) instead of raw per-environment project titles when repository grouping is enabled.

buildHomeProjectScopes and thread group building always call deriveProjectGroupLabel, so a single project in a repo scope shows the repository label rather than a local worktree name. Project filter chips and menus are built from those scopes via buildHomeProjectScopes, respecting grouping mode.

Selecting a scope filters threads and pending tasks across every projectRef in that scope (not a single raw project). Thread List V2 rows receive an optional projectTitle so favicons and row text match the scope label on phone and tablet.

The thread-list filter menu no longer includes a Settings action (settings remain on the header); tests assert that removal.

Reviewed by Cursor Bugbot for commit 22a0ac5. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix project grouping labels on mobile home screen to use repository display names

  • Updates buildHomeProjectScopes and buildHomeThreadGroups in homeThreadList.ts to always derive scope/group titles via deriveProjectGroupLabel, even for single-project scopes, so repository display names appear instead of raw project titles.
  • Updates HomeScreen and ThreadNavigationSidebarPane to map project keys to scope-level titles and pass them to ThreadListV2Row, which now accepts an optional projectTitle prop with fallback to project.title.
  • Replaces per-project filter entries in HomeRouteScreen with buildHomeProjectScopes, so the Project submenu reflects grouped scopes and reacts to projectGroupingMode.
  • Removes the Settings action from the thread list options menu in home-list-filter-menu.ts and HomeHeader.
  • Behavioral Change: project filter selection now scopes threads and pending tasks across multiple projects within a grouped scope.

Macroscope summarized 22a0ac5.

Co-authored-by: codex <codex@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 17a74ffe-c024-4c73-936b-85d2c59aebfe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-mobile-project-grouping

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 23, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is ON, but a cloud agent failed to start.

Reviewed by Cursor Bugbot for commit a564952. Configure here.

Comment thread apps/mobile/src/features/home/HomeScreen.tsx
Comment thread apps/mobile/src/features/home/homeThreadList.ts
Comment thread apps/mobile/src/features/home/HomeRouteScreen.tsx
@macroscopeapp

macroscopeapp Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Straightforward bug fix for project label display on mobile when using repository grouping mode. Changes are self-contained to the home/threads UI, reuse existing grouping logic, and include test coverage for the fix.

You can customize Macroscope's approvability policy. Learn more.

Co-authored-by: codex <codex@users.noreply.github.com>
@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Jul 23, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 23, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
@macroscopeapp
macroscopeapp Bot dismissed their stale review July 23, 2026 20:49

Dismissing prior approval to re-evaluate 22a0ac5

@juliusmarminge
juliusmarminge merged commit b3e5131 into main Jul 23, 2026
16 checks passed
@juliusmarminge
juliusmarminge deleted the codex/fix-mobile-project-grouping branch July 23, 2026 20:57
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 25, 2026
pingdotgg#4396) (#186)

* [codex] Move project grouping to General settings (pingdotgg#4313)

Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit 7609495)

* [codex] Group project scopes in mobile thread lists (pingdotgg#4314)

Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit 0542abc)

* [codex] Move mobile project grouping to General settings (pingdotgg#4315)

Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit 719c905)

* [codex] Deduplicate connection failure messaging (pingdotgg#4367)

Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit 315b273)

* Restore grouped project filtering in Sidebar V2 (pingdotgg#4282)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit 3afb4a9)

* [codex] restore Sidebar V2 project actions (pingdotgg#4373)

Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit 57100fb)

* [codex] Group projects in new-thread pickers (pingdotgg#4312)

Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit 9d9208c)

* fix(web): restore dark composer toolbar styling

(cherry picked from commit 9cbe50d)

* Fix thread tooltip folder icon color (pingdotgg#4383)

(cherry picked from commit 9798548)

* fix(server): parse CLI version in update preflight (pingdotgg#4389)

(cherry picked from commit 88c69ff)

* fix(web): sidebar v2 polish — jump hints, working duration, in-flight fade, settled sort (pingdotgg#4274)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
(cherry picked from commit ddd5a46)

* Fix logical project grouping labels on mobile (pingdotgg#4391)

Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit b3e5131)

* Add preview color scheme controls and simplify project grouping (pingdotgg#4385)

Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
(cherry picked from commit 79fe11b)

* fix(cli): publish nightly branded favicons (pingdotgg#4372)

(cherry picked from commit edb1240)

* Fix thread loading flash (pingdotgg#4396)

(cherry picked from commit 91dfe60)

---------

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: maria <maria@kuuro.net>
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant