test(orchestrator): align Codex approval reviewer replays

[juliusmarminge]

Summary

• update every deterministic Codex turn/start expectation with the explicit approvalsReviewer: user field now emitted by the adapter
• preserve exact replay matching for reviewer-mode transitions
• unblock the identical 23-test failure affecting the current target and all three remaining merge-lane PRs

Verification

• OrchestratorReplayFixtures.integration.test.ts -t codex: 18 passed
• OrchestratorReplayRecovery.integration.test.ts -t Codex: 1 passed
• ThreadFork.integration.test.ts -t Codex: 2 passed
• ThreadMergeBack.integration.test.ts -t codex: 2 passed
• targeted project lint/format checks passed (NDJSON is ignored by the formatter; the adjacent replay test was checked)
• git diff --check passed

---

Note

Low Risk
Test fixture updates only; no production behavior changes.

Overview
Updates deterministic Codex app-server replay fixtures so every turn/start expect_outbound frame includes approvalsReviewer: "user", matching what the Codex adapter now sends on outbound turns.

This is a fixture-only change across orchestration-v2 testkit scenarios (simple turns, multi-turn, steering, plan mode, forks, subagents, merge-back, etc.); no runtime code is modified. Replay tests should match adapter output again instead of failing on the missing field.

^{Reviewed by Cursor Bugbot for commit 4b16961. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add approvalsReviewer:"user" to Codex orchestrator replay fixtures

Updates all codex_transcript.ndjson replay fixtures in the orchestration-v2 testkit to include approvalsReviewer: "user" in the params object of every expect_outbound turn/start frame. This aligns the fixtures with the current expected behavior where the approvals reviewer is set to "user" on each turn start.

^{Macroscope summarized 4b16961.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 99ef7d77-1092-4be0-a21e-8884553cfc03

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/fix-codex-replay-approvals-reviewer

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved

Test-only change adding approvalsReviewer field consistently across 27 test fixture files. No production code modified, purely mechanical alignment of test replay data.

^{You can customize Macroscope's approvability policy. Learn more.}