Skip to content

fix: close actions dropdown when editing #4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 2 commits into from
Jul 27, 2026
Merged

fix: close actions dropdown when editing #4660

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c715a5
fix: close actions dropdown when editing
0x4bs3nt Jul 27, 2026
31e5c65
fix: isolate project actions menu state
0x4bs3nt Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions apps/web/src/components/ProjectScriptsControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,10 @@ export default function ProjectScriptsControl({
}: ProjectScriptsControlProps) {
const addScriptFormId = React.useId();
const [editingScriptId, setEditingScriptId] = useState<string | null>(null);
const [actionsMenuOpen, setActionsMenuOpen] = useState({
scripts: false,
imports: false,
});
const [dialogOpen, setDialogOpen] = useState(false);
const [name, setName] = useState("");
const [command, setCommand] = useState("");
Expand Down Expand Up @@ -255,6 +259,7 @@ export default function ProjectScriptsControl({
};

const openEditDialog = (script: ProjectScript) => {
setActionsMenuOpen({ scripts: false, imports: false });
setEditingScriptId(script.id);
setName(script.name);
setCommand(script.command);
Expand Down Expand Up @@ -349,7 +354,11 @@ export default function ProjectScriptsControl({
<TooltipPopup side="top">Run {primaryScript.name}</TooltipPopup>
</Tooltip>
<GroupSeparator className="hidden @3xl/header-actions:block" />
<Menu highlightItemOnHover={false}>
<Menu
highlightItemOnHover={false}
open={actionsMenuOpen.scripts}
onOpenChange={(open) => setActionsMenuOpen({ scripts: open, imports: false })}
>
<MenuTrigger
render={<Button size="icon-xs" variant="outline" aria-label="Script actions" />}
>
Expand Down Expand Up @@ -408,7 +417,11 @@ export default function ProjectScriptsControl({
</Menu>
</Group>
) : importableScripts.length > 0 ? (
<Menu highlightItemOnHover={false}>
<Menu
highlightItemOnHover={false}
open={actionsMenuOpen.imports}
onOpenChange={(open) => setActionsMenuOpen({ scripts: false, imports: open })}
>
<MenuTrigger render={<Button size="xs" variant="outline" aria-label="Project actions" />}>
<PlusIcon className="size-3.5" />
<span className="sr-only @3xl/header-actions:not-sr-only @3xl/header-actions:ml-0.5">
Expand Down
Loading