Skip to content

fix(web): align remote server update action - #4731

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
StiensWout:fix/remote-update-action-alignment
Jul 30, 2026
Merged

fix(web): align remote server update action#4731
maria-rcks merged 1 commit into
pingdotgg:mainfrom
StiensWout:fix/remote-update-action-alignment

Conversation

@StiensWout

@StiensWout StiensWout commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move the remote server update control into the row's right-aligned action rail
  • keep the version-drift warning in the content column
  • render the update action only while a version mismatch exists
  • preserve the existing semantic warning and button tokens in light and dark themes

Root cause

ServerUpdateAction was rendered inline beside the version-drift message, while Disconnect lived in the row's dedicated action column. The two controls therefore used unrelated alignment contexts.

Validation

  • corepack pnpm exec vp fmt --check apps/web/src/components/settings/ConnectionsSettings.tsx
  • corepack pnpm exec vp lint apps/web/src/components/settings/ConnectionsSettings.tsx --report-unused-disable-directives
  • corepack pnpm exec vp run --filter @t3tools/web typecheck
  • corepack pnpm exec vp test run src/components/ServerUpdateAction.test.tsx --project unit from apps/web (3 tests passed)
  • isolated web verification against a live mismatched remote backend in light and dark themes
  • verified the real Updating... state keeps the update and disconnect controls aligned
  • verified a matching-version remote renders neither the drift warning nor an update action

Screenshots

Theme Before After
Light Before in light mode After in light mode
Dark Before in dark mode After in dark mode

Current main compatibility

  • based on 3c50a648
  • focused regression tests and targeted package type checks passed
  • targeted formatting and lint passed
  • git diff --check passed

Note

Low Risk
Layout-only JSX move in Connections settings; no change to update logic or server interaction.

Overview
Saved remote environment rows in Connections settings now keep the version-drift warning in the left content column and place ServerUpdateAction in the same right-aligned action rail as Connect/Disconnect/Remove.

Previously the update control sat inline next to the warning while disconnect lived in the action column, so the two controls could misalign (including during Updating…). Behavior is unchanged: the warning and update UI still appear only when resolveServerConfigVersionMismatch reports a mismatch.

Reviewed by Cursor Bugbot for commit 4c74038. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Move server update action button to the actions area in remote server list rows

In SavedBackendListRow, the ServerUpdateAction button was previously rendered inline with the version drift warning text. It is now rendered in the right-side actions section alongside other row action buttons, matching the layout of the rest of the row.

Macroscope summarized 4c74038.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3155b488-08fa-4595-822f-780ea2cc97eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Jul 28, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

This PR relocates the ServerUpdateAction component to a different position in the UI layout for alignment purposes. The component, its props, and conditional rendering logic remain unchanged - this is a purely cosmetic repositioning with no runtime behavior impact.

You can customize Macroscope's approvability policy. Learn more.

@maria-rcks
maria-rcks merged commit 6efcf3e into pingdotgg:main Jul 30, 2026
16 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Jul 30, 2026
## What's Changed
* docs: link iOS and Android app store downloads by @t3dotgg in pingdotgg/t3code#4902
* fix(web): align remote server update action by @StiensWout in pingdotgg/t3code#4731


**Full Changelog**: pingdotgg/t3code@v0.0.32-nightly.20260730.953...v0.0.32-nightly.20260730.954

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.32-nightly.20260730.954
tarik02 added a commit to tarik02-org/t3code that referenced this pull request Jul 30, 2026
* fix(desktop): restore T3 Connect sign-in (pingdotgg#4809)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* Simplify files panel header (pingdotgg#4828)

* build(desktop): reduce installed app size by ~300MB (pingdotgg#4824)

* Update model version from claude-opus-4-8 to claude-opus-5 (pingdotgg#4832)

* Preserve the thread shell while detail loads (pingdotgg#4830)

* Reduce idle work and disk churn with native resource diagnostics (pingdotgg#2679)

Co-authored-by: codex <codex@users.noreply.github.com>

* fix(server): detect repositories after initialization (pingdotgg#4848)

* perf(server): merge separate staged/unstaged numstat calls into single diff HEAD --numstat (pingdotgg#4843)

* fix(git): disable external diff for review diff previews (pingdotgg#4854)

* Fix editable file focus and live syntax highlighting (pingdotgg#3979)

* fix(web): remember the rendered-markdown choice across threads (pingdotgg#4853)

Co-authored-by: Simon Doba <simon.doba@orbit.de>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

* chore(release): prepare v0.0.31

* fix(mobile): reduce thread feed scroll jank (pingdotgg#4874)

* fix(web): restore sidebar v2 thread actions and terminal icon (pingdotgg#4712)

* fix(web): settle button now works on hover, not just right-click (pingdotgg#4905)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(clients): disable add project while disconnected (pingdotgg#4834)

* fix(composer): hide default Codex service tier (pingdotgg#4784)

* docs: link iOS and Android app store downloads (pingdotgg#4902)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(web): align remote server update action (pingdotgg#4731)

* fix(connect): suggest a serve command that matches how you ran connect (pingdotgg#4897)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(mobile): stop shared content errors in Personal Team builds (pingdotgg#4943)

* perf(mobile): sends respond instantly, thread opens stop freezing (pingdotgg#4882)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(web): show Codex fast mode as a bolt (pingdotgg#4947)

* docs: seed worktrees with a copy of real userdata instead of banning it (pingdotgg#4949)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(mobile): support dragged images in the composer (pingdotgg#4953)

* fix(mobile): stop long iOS threads from jumping while scrolling up (pingdotgg#4867)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(web): keep worktree default when switching a draft's machine (pingdotgg#4964)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* perf(mobile): reconnect environments immediately on resume (pingdotgg#4878)

* feat(web): pasting a huge screenshot now compresses it instead of erroring (pingdotgg#4967)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* feat(web): regenerate thread titles from sidebar (pingdotgg#4810)

* fix(web): show server update progress through reconnect (pingdotgg#4903)

---------

Co-authored-by: Alex <me@pixp.cc>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: wukko <me@wukko.me>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com>
Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com>
Co-authored-by: ohbentos <72638975+ohbentos@users.noreply.github.com>
Co-authored-by: Jake Leventhal <jakeleventhal@me.com>
Co-authored-by: Simon Doba <simon.doba@hotmail.de>
Co-authored-by: Simon Doba <simon.doba@orbit.de>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Gabriel De Andrade <30420087+gabrielelpidio@users.noreply.github.com>
Co-authored-by: Jono Kemball <Noojuno@users.noreply.github.com>
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Max Katz <me@maxkatz.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants