Skip to content

perf(server): fix N+1 PowerShell process query and reduce sampling frequency #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
UtkarshUsername wants to merge 5 commits into from
Closed

perf(server): fix N+1 PowerShell process query and reduce sampling frequency #4829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
30a6121
fix(server): eliminate N+1 PowerShell CIM query on Windows process di…
UtkarshUsername Jul 29, 2026
2db1250
perf(server): reduce process resource sampling interval from 5s to 15s
UtkarshUsername Jul 29, 2026
a8e541a
Merge branch 'main' into fix/perf-resource-monitor-n-plus-1
UtkarshUsername Jul 29, 2026
d4e0cc3
Merge branch 'main' into fix/perf-resource-monitor-n-plus-1
UtkarshUsername Jul 29, 2026
9d9363e
Merge branch 'main' into fix/perf-resource-monitor-n-plus-1
UtkarshUsername Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apps/server/src/diagnostics/ProcessDiagnostics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,11 +443,11 @@ function readWindowsProcessRows(): Effect.Effect<
ChildProcessSpawner.ChildProcessSpawner
> {
const command = [
"$processes = Get-CimInstance Win32_Process | ForEach-Object {",
'$perf = Get-CimInstance Win32_PerfFormattedData_PerfProc_Process -Filter "IDProcess = $($_.ProcessId)" -ErrorAction SilentlyContinue;',
"[pscustomobject]@{ ProcessId = $_.ProcessId; ParentProcessId = $_.ParentProcessId; Name = $_.Name; CommandLine = $_.CommandLine; Status = $_.Status; WorkingSetSize = $_.WorkingSetSize; PercentProcessorTime = if ($perf) { $perf.PercentProcessorTime } else { 0 } }",
"};",
"$processes | ConvertTo-Json -Compress -Depth 3",
"$perfData=@{};Get-CimInstance Win32_PerfFormattedData_PerfProc_Process -ErrorAction SilentlyContinue|ForEach-Object{$perfData[$_.IDProcess]=$_};",
"Get-CimInstance Win32_Process|ForEach-Object{",
"$perf=$perfData[$_.ProcessId];",
"[pscustomobject]@{ProcessId=$_.ProcessId;ParentProcessId=$_.ParentProcessId;Name=$_.Name;CommandLine=$_.CommandLine;Status=$_.Status;WorkingSetSize=$_.WorkingSetSize;PercentProcessorTime=if($perf){$perf.PercentProcessorTime}else{0}}",
"}|ConvertTo-Json -Compress -Depth 3",
].join(" ");

return runProcess({
Expand Down
4 changes: 2 additions & 2 deletions apps/server/src/diagnostics/ProcessResourceMonitor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ describe("ProcessResourceMonitor", () => {
expect(result.topProcesses).toHaveLength(1);
expect(result.topProcesses[0]?.avgCpuPercent).toBe(20);
expect(result.topProcesses[0]?.maxCpuPercent).toBe(30);
expect(result.topProcesses[0]?.cpuSecondsApprox).toBe(2);
expect(result.totalCpuSecondsApprox).toBe(2);
expect(result.topProcesses[0]?.cpuSecondsApprox).toBe(6);
expect(result.totalCpuSecondsApprox).toBe(6);
expect(result.buckets.some((bucket) => bucket.maxCpuPercent === 30)).toBe(true);
}),
);
Expand Down
2 changes: 1 addition & 1 deletion apps/server/src/diagnostics/ProcessResourceMonitor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import * as ChildProcessSpawner from "effect/unstable/process/ChildProcessSpawne

import * as ProcessDiagnostics from "./ProcessDiagnostics.ts";

const SAMPLE_INTERVAL_MS = 5_000;
const SAMPLE_INTERVAL_MS = 15_000;
const RETENTION_MS = 60 * 60_000;
const MAX_RETAINED_SAMPLES = 20_000;

Expand Down
Loading