Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/mobile/src/features/sharing/IncomingShareProvider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
type IncomingShareDestination,
type IncomingShareDraft,
} from "./incoming-share-model";
import { createIncomingSharePayloadReader } from "./incoming-share-native";
import { IncomingShareInbox } from "./incoming-share-inbox";
import {
loadIncomingShareDrafts,
Expand Down Expand Up @@ -48,6 +49,11 @@ function receiveSharingEnabled(): boolean {
return Constants.expoConfig?.extra?.iosPersonalTeamBuild !== true;
}

const getIncomingSharePayloads = createIncomingSharePayloadReader({
platform: Platform.OS,
readPayloads: getSharedPayloads,
});

async function resolvedPayloadsForImages(): Promise<ReadonlyArray<ResolvedSharePayload>> {
try {
return await getResolvedSharedPayloadsAsync();
Expand Down Expand Up @@ -121,7 +127,7 @@ const incomingShareInbox = new IncomingShareInbox({
loadDrafts: loadIncomingShareDrafts,
writeDraft: writeIncomingShareDraft,
removeDraft: removeIncomingShareDraft,
getPayloads: getSharedPayloads,
getPayloads: getIncomingSharePayloads,
clearPayloads: clearSharedPayloads,
buildDraft: async ({ payloads, id, createdAt }) => {
const cleanupUris = new Set<string>();
Expand Down
46 changes: 46 additions & 0 deletions apps/mobile/src/features/sharing/incoming-share-native.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
import { describe, expect, it, vi } from "@effect/vitest";
import type { SharePayload } from "expo-sharing";

import { createIncomingSharePayloadReader } from "./incoming-share-native";

const PAYLOAD: SharePayload = {
shareType: "text",
mimeType: "text/plain",
value: "Fix this",
};

describe("createIncomingSharePayloadReader", () => {
it("treats a missing iOS App Group as an unavailable inbox", () => {
const readPayloads = vi.fn((): ReadonlyArray<SharePayload> => {
throw Object.assign(new Error("Expo-sharing has failed to fetch the app group id"), {
code: "ERR_FAILED_TO_RESOLVE_APP_GROUP_ID",
});
});
const read = createIncomingSharePayloadReader({ platform: "ios", readPayloads });

expect(read()).toEqual([]);
expect(read()).toEqual([]);
expect(readPayloads).toHaveBeenCalledTimes(1);
});

it("returns native payloads when receiving is available", () => {
const read = createIncomingSharePayloadReader({
platform: "ios",
readPayloads: () => [PAYLOAD],
});

expect(read()).toEqual([PAYLOAD]);
});

it("preserves other native errors", () => {
const error = new Error("native failure");
const read = createIncomingSharePayloadReader({
platform: "ios",
readPayloads: () => {
throw error;
},
});

expect(read).toThrow(error);
});
});
37 changes: 37 additions & 0 deletions apps/mobile/src/features/sharing/incoming-share-native.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import type { SharePayload } from "expo-sharing";

const IOS_APP_GROUP_UNAVAILABLE_ERROR_CODE = "ERR_FAILED_TO_RESOLVE_APP_GROUP_ID";

function errorCode(error: unknown): string | null {
if (typeof error !== "object" || error === null || !("code" in error)) {
return null;
}
return typeof error.code === "string" ? error.code : null;
}

/**
* Normalizes the native "share into" capability to an empty inbox. Personal
* Team builds cannot include the App Group that expo-sharing reads from.
*/
export function createIncomingSharePayloadReader(input: {
readonly platform: string;
readonly readPayloads: () => ReadonlyArray<SharePayload>;
}): () => ReadonlyArray<SharePayload> {
let isUnavailable = false;

return () => {
if (isUnavailable) {
return [];
}

try {
return input.readPayloads();
} catch (error) {
if (input.platform === "ios" && errorCode(error) === IOS_APP_GROUP_UNAVAILABLE_ERROR_CODE) {
isUnavailable = true;
return [];
}
throw error;
}
};
}
Loading