fix(mobile): support pre-Liquid-Glass iOS bottom toolbar - #4984
Conversation
- Fall back to standard search and toolbar primitives on older iOS - Preserve bottom-toolbar spacing and list content insets
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review This PR changes runtime UI behavior across multiple screens to support pre-Liquid-Glass iOS versions, including conditional toolbar rendering, search placement changes, and padding adjustments. The multi-screen scope and feature flag interactions warrant verification that both old and new iOS versions behave as expected. You can customize Macroscope's approvability policy. Learn more. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2488a2d. Configure here.
…tom-toolbar # Conflicts: # apps/mobile/src/features/home/HomeScreen.tsx
## What's Changed * fix(mobile): support pre-Liquid-Glass iOS bottom toolbar by @gabrielelpidio in pingdotgg/t3code#4984 * fix(server): restore PR detection without HOME by @StiensWout in pingdotgg/t3code#4985 * fix(web): fill fast mode icon by @maria-rcks in pingdotgg/t3code#5004 * fix: cache project favicons across web and mobile by @gabrielelpidio in pingdotgg/t3code#4767 * perf(ci): cut stale runs and redundant setup by @t3dotgg in pingdotgg/t3code#4802 **Full Changelog**: pingdotgg/t3code@v0.0.32-nightly.20260730.957...v0.0.32-nightly.20260730.958 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.32-nightly.20260730.958
) (cherry picked from commit 323dc32)
sync: port upstream mobile perf, OTA updates, Thread List v2 default (pingdotgg#4607–pingdotgg#4984)

What Changed
Added a fallback bottom toolbar for iOS versions before Liquid Glass support. Older iOS versions now use standard navigation search and toolbar primitives, while iOS 26 continues using the native Liquid Glass toolbar integration.
Why
The native mail-style toolbar is only supported by the iOS 26 Liquid Glass implementation. On older iOS versions, those toolbar items were silently dropped, leaving search and thread actions unavailable. This restores the expected controls across supported iOS versions.
UI Changes
Checklist
Note
Low Risk
UI-only navigation chrome and list inset changes on older iOS; Liquid Glass paths stay gated behind the existing capability flag with no auth or data-layer impact.
Overview
On iOS without Liquid Glass, the native mail-style header toolbar was dropped entirely, so search, filters, and new-task were missing. This PR gates that integration behind
NATIVE_MAIL_SEARCH_TOOLBAR_SUPPORTEDand restores standard pull-down search plus a bottomNativeHeaderToolbaron home (and aligned behavior on archived threads and thread files).Home moves filter/sort and new-task into the fallback bottom bar; thread list v2 still hides sort menus when sorting is ignored.
HomeScreenadds 44pt list padding and scroll inset clearance so list content isn’t covered by the overlay toolbar when automatic inset adjustment is off.StackHeadersupports a flexible spacer and assigns spacing item index so spacers don’t jump ahead of earlier toolbar siblings.Reviewed by Cursor Bugbot for commit 591a7f1. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix mobile home screen layout and toolbar for pre-Liquid-Glass iOS
NATIVE_MAIL_SEARCH_TOOLBAR_SUPPORTEDflag (aliasingNATIVE_LIQUID_GLASS_SUPPORTED) to gate use of the integrated mail-style toolbar to iOS 26+.HomeHeaderfalls back to a pull-down search bar and renders a bottom toolbar with filter menus and a compose button instead of the integrated toolbar.HomeScreenreserves 44pt of bottom padding on pre-Liquid-Glass iOS to prevent list content from being obscured by the bottom toolbar overlay.ArchivedThreadsScreenandThreadFilesRouteScreensimilarly gate compact mail toolbar andintegratedButtonsearch placement behind the new flag.NativeHeaderToolbarSpacerto support aflexibleprop and corrects insertion-order bugs for spacing items in native header toolbars.Macroscope summarized 591a7f1.