feat(mobile): add a refresh-all button to the environments screen - #5022
feat(mobile): add a refresh-all button to the environments screen#5022carTloyal123 wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 89e4504 Simple additive UI change that adds a refresh-all button. The implementation reuses existing You can customize Macroscope's approvability policy. Learn more. |
Adds an `arrow.clockwise` button to the Environments settings header, alongside the existing add-environment button, that retries every registered environment at once. This is not a placebo refresh. `onReconnectEnvironment` bottoms out in `environmentCatalog.retryNow`, which short-circuits the reconnect backoff — so this is the one way to escape a long backoff delay without waiting it out, which is exactly the moment a user is staring at a stale list wanting to do something about it. It pairs with the workspace status indicator, which already navigates here: the status reports that something is wrong, and this is the remedy. Disabled when there are no environments registered, so it can never be a dead tap. Wired into both header styles — NativeHeaderToolbar on iOS and AndroidScreenHeader actions on Android. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
eaa5f9a to
89e4504
Compare
Dismissing prior approval to re-evaluate 89e4504
|
Honestly this is slop, sorry :/ |
What changed
Adds an
arrow.clockwisebutton to the Environments settings header, next to the existing add-environment button, that retries every registered environment at once.Why it earns its place
This is not a placebo refresh.
onReconnectEnvironmentbottoms out inenvironmentCatalog.retryNow, which short-circuits the reconnect backoff — so it is the one way to escape a long backoff delay without waiting it out. That is exactly the moment a user is staring at a stale list wanting to do something about it.It also pairs with the workspace status indicator, which already navigates to this screen: the status reports that something is wrong, and this is the remedy sitting where the user lands.
Details
NativeHeaderToolbaron iOS,AndroidScreenHeaderactions on Android.Verification
tsc --noEmitcleanNo screenshots: this adds one standard header icon button in the existing toolbar and changes nothing else visually.
Kept separate from the status-bar fix so the two stay independently reviewable.
Note
Low Risk
UI-only addition reusing existing reconnect plumbing; no new auth or data paths, with harmless duplicate retries for already-connected environments.
Overview
Adds a refresh all header action on the Environments settings screen so users can trigger reconnect for every registered environment in one tap.
handleRefreshAllloopsconnectedEnvironmentsand callsonReconnectEnvironmentfor each id (backed byretryNow, so it can skip long reconnect backoff). Thearrow.clockwisecontrol is disabled when there are no environments. The same action is wired on Android (AndroidScreenHeaderactions) and iOS (NativeHeaderToolbar.Button), with ordering comments so both platforms show refresh beside the existing add button.Reviewed by Cursor Bugbot for commit 89e4504. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add a refresh-all button to the environments settings screen
Adds a "Refresh all environments" toolbar button to SettingsEnvironmentsRouteScreen that calls
onReconnectEnvironmentfor every connected environment. The button is disabled when no environments are connected. On Android it appears before the add button; on iOS it appears after (due to UIKit ordering).Macroscope summarized 89e4504.