Skip to content

fix(web): align sidebar settle hit area - #5333

Closed
IGN-Styly wants to merge 3 commits into
pingdotgg:mainfrom
IGN-Styly:agent/fix-settle-button-hit-area
Closed

fix(web): align sidebar settle hit area#5333
IGN-Styly wants to merge 3 commits into
pingdotgg:mainfrom
IGN-Styly:agent/fix-settle-button-hit-area

Conversation

@IGN-Styly

@IGN-Styly IGN-Styly commented Aug 4, 2026

Copy link
Copy Markdown

Summary

Fixes #5330.

The Sidebar V2 card row showed the Settle control, but its visible label did not match the clickable area. Clicking the gap beside Snooze worked while clicking the displayed Settle text could miss the action.

Root cause

The status label and lifecycle actions share one slot. The action layer remained pointer-active while hidden and could stack above the status label during the hover transition.

Changes

  • Disable pointer events on the hidden action layer.
  • Restore pointer events when hover or keyboard focus reveals the actions.
  • Raise the action layer above the status label.

Validation

  • Web typecheck
  • Sidebar logic tests: 87 passed
  • Targeted lint and formatting
  • Web production build

Note

Fix sidebar row controls to not intercept pointer events when hidden

The controls container in SidebarV2Row was capturing pointer events even when invisible, interfering with adjacent content. Adds pointer-events-none by default and restores pointer-events-auto only on hover, focus-visible, or when the snooze menu is open. Also adds z-10 so the controls render above adjacent content when visible.

Macroscope summarized ed19dd6.


Note

Low Risk
CSS-only interaction fix in sidebar row markup with no API or data changes; behavior is limited to when clicks reach Settle/Snooze vs the status slot.

Overview
Fixes #5330 — on Sidebar V2 card rows, clicks on the visible status/time text could miss while empty space near Snooze still hit Settle, because the lifecycle action strip stayed pointer-active while faded out and could sit above the label during hover transitions.

The Settle/Snooze container in SidebarV2Row now uses pointer-events-none when hidden, pointer-events-auto when shown (row hover, :focus-visible on a control, or open snooze menu), and z-10 so revealed controls stack correctly. The status label already ignored pointer events while invisible; this applies the same idea to the action layer.

Reviewed by Cursor Bugbot for commit ed19dd6. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7d079b0d-7d7c-499d-9927-1caeda3a73ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 4, 2026
@IGN-Styly
IGN-Styly marked this pull request as ready for review August 4, 2026 12:27
@macroscopeapp

macroscopeapp Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved a9f00fd

This PR makes minor CSS class changes to fix sidebar hit area targeting. The modifications only affect pointer-events and z-index styling with no logic or runtime behavior changes beyond UI interaction.

You can customize Macroscope's approvability policy. Learn more.

@t3-code

t3-code Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

closing as superseded by #5486. its merged SidebarV2 changes make hidden action layers ignore pointer events and restore them when the actions are visible, covering the same settle hit-area fix. thanks for the work here.

@t3-code t3-code Bot closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Settle button not matching display

1 participant