fix(web): align sidebar settle hit area - #5333
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved a9f00fd This PR makes minor CSS class changes to fix sidebar hit area targeting. The modifications only affect pointer-events and z-index styling with no logic or runtime behavior changes beyond UI interaction. You can customize Macroscope's approvability policy. Learn more. |
|
closing as superseded by #5486. its merged SidebarV2 changes make hidden action layers ignore pointer events and restore them when the actions are visible, covering the same settle hit-area fix. thanks for the work here. |
Summary
Fixes #5330.
The Sidebar V2 card row showed the Settle control, but its visible label did not match the clickable area. Clicking the gap beside Snooze worked while clicking the displayed Settle text could miss the action.
Root cause
The status label and lifecycle actions share one slot. The action layer remained pointer-active while hidden and could stack above the status label during the hover transition.
Changes
Validation
Note
Fix sidebar row controls to not intercept pointer events when hidden
The controls container in
SidebarV2Rowwas capturing pointer events even when invisible, interfering with adjacent content. Addspointer-events-noneby default and restorespointer-events-autoonly on hover, focus-visible, or when the snooze menu is open. Also addsz-10so the controls render above adjacent content when visible.Macroscope summarized ed19dd6.
Note
Low Risk
CSS-only interaction fix in sidebar row markup with no API or data changes; behavior is limited to when clicks reach Settle/Snooze vs the status slot.
Overview
Fixes #5330 — on Sidebar V2 card rows, clicks on the visible status/time text could miss while empty space near Snooze still hit Settle, because the lifecycle action strip stayed pointer-active while faded out and could sit above the label during hover transitions.
The Settle/Snooze container in
SidebarV2Rownow usespointer-events-nonewhen hidden,pointer-events-autowhen shown (row hover,:focus-visibleon a control, or open snooze menu), andz-10so revealed controls stack correctly. The status label already ignored pointer events while invisible; this applies the same idea to the action layer.Reviewed by Cursor Bugbot for commit ed19dd6. Bugbot is set up for automated code reviews on this repo. Configure here.