Skip to content

fix(mobile): restore Android tablet thread controls, clean up header - #5385

Open
PixPMusic wants to merge 6 commits into
pingdotgg:mainfrom
PixPMusic:pixpmusic/fix-android-tablet-header
Open

fix(mobile): restore Android tablet thread controls, clean up header#5385
PixPMusic wants to merge 6 commits into
pingdotgg:mainfrom
PixPMusic:pixpmusic/fix-android-tablet-header

Conversation

@PixPMusic

@PixPMusic PixPMusic commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • restore the compact T3 Code brand lockup in the Android split-view thread sidebar
  • align the lockup with the primary thread-title column
  • use the shared settings control instead of the divergent Android-native gear glyph
  • expose the existing Android new-task FAB inside the persistent sidebar and keep list rows clear of it
  • remove the empty Android detail pane's blank native-header wash
  • keep the focused new-thread composer and toolbar attached to the Android keyboard, matching existing threads

Why

Android tablets and unfolded foldables use a separate split-view sidebar once the window reaches 720dp × 600dp. That sidebar had drifted from the phone surface: it showed a hardcoded “Threads” title, a different settings icon, and no persistent way to start a task.

The new-thread screen also used padding-based keyboard avoidance while existing threads used a frame-synced sticky composer. On a foldable, the IME could cover the new-thread toolbar even though the existing-thread toolbar remained visible.

The empty split-view detail route still mounted a blank Android native header, leaving a lighter strip and divider above the otherwise uniform detail background.

This addresses the header, settings, and new-task portions of #5338. Sidebar collapse is intentionally outside this focused PR.

UI Changes

Before After
Android unfolded Fold sidebar before, showing the Threads title, sun-like settings icon, and no compose control Android unfolded Fold sidebar after, showing the T3 Code Alpha lockup, shared settings gear, and compose FAB

Both captures use the same deterministic dark-mode Threads fixture on an unfolded Pixel 9 Pro Fold AVD at its native 2076×2152 display size. Every “After” capture below was regenerated from the exact PR head (1a9de543f) using the production/Alpha variant in one emulator session.

Final baseline and empty-detail proof

Android unfolded Fold final layout, with the T3 Code lockup aligned to thread titles and a uniform empty-detail background

New thread with keyboard open

Android unfolded Fold new-thread composer after the fix, with its editor and controls visible above the open keyboard

Verification

  • pnpm --filter @t3tools/mobile typecheck
  • targeted formatting and lint for the changed mobile files
  • git diff --check
  • matched before/after pass on the real pixel_9_pro_fold Android hardware profile
  • focused new-thread pass with the IME open; editor and toolbar accessibility bounds remain above the keyboard
  • one fresh Codex review and one Claude Opus counter-review; the actionable animation and large-font clipping findings were addressed

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for the UI changes
  • No new animation behavior was introduced

Model: GPT-5.6 Sol | Harness: Codex in T3 Code


Note

Low Risk
Focused Android/iOS mobile UI and keyboard layout changes with no auth, data, or API impact; main risk is regressions on split-view navigation and IME overlap on new-thread compose.

Overview
Brings Android split-view (tablet/foldable) thread navigation in line with phone surfaces: the sidebar shows the T3 Code lockup instead of a hardcoded “Threads” title, uses the shared settings control (the Android-only header-actions file is removed), and gets the same bottom-right new task FAB via AndroidHomeFabLayout on the persistent sidebar—with extra list bottom inset so rows clear the FAB.

Split-view Home hides the empty detail pane’s native stack header on Android (headerShown: false); leaving split view explicitly restores headerShown: true when re-applying connection-aware brand options. CompactBrandTitle gains optional allowFontScaling (enabled for iOS nav bar rendering, disabled in the sidebar lockup).

On new thread (Android), the composer toolbar moves from padding-based KeyboardAvoidingView to KeyboardStickyView so it tracks the IME like existing thread composers. The sidebar sticky header drops scroll-driven gradient wash in favor of a solid drawer background.

Reviewed by Cursor Bugbot for commit 211d96b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Restore Android tablet thread controls and clean up split-view header

  • Adds a new-task FAB overlay to the thread navigation sidebar on Android tablets within split layouts by wrapping ThreadNavigationSidebar in AndroidHomeFabLayout inside AdaptiveWorkspaceLayout.tsx.
  • Replaces the plain 'Threads' label in the sidebar header with CompactBrandTitle (font scaling disabled on Android) and removes the scroll-based header wash gradient from ThreadNavigationSidebar.tsx.
  • Hides the navigation header in Android split-view and explicitly restores it with connection-aware brand options when leaving split view in HomeRouteScreen.tsx.
  • Switches the Android composer in NewTaskDraftScreen from KeyboardAvoidingView to KeyboardStickyView, fixing control positioning during text input.
  • Deletes the now-unused sidebar-header-actions.android.tsx.

Macroscope summarized 211d96b.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1b9c2d92-b47f-4676-8c01-3b44573f6290

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 5, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 211d96b

Mobile UI fix restoring Android tablet FAB controls and simplifying header styling. Changes are self-contained platform-specific adjustments with no business logic impact, removing ~30 lines of gradient effects and consolidating header behavior.

You can customize Macroscope's approvability policy. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 5, 2026
@PixPMusic
PixPMusic force-pushed the pixpmusic/fix-android-tablet-header branch from 4f7fc48 to be61e0b Compare August 5, 2026 07:50
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 5, 2026 07:50

Dismissing prior approval to re-evaluate be61e0b

@PixPMusic
PixPMusic force-pushed the pixpmusic/fix-android-tablet-header branch from be61e0b to 73931e8 Compare August 5, 2026 07:52
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 5, 2026
@PixPMusic
PixPMusic force-pushed the pixpmusic/fix-android-tablet-header branch from 73931e8 to 25db0c1 Compare August 5, 2026 08:03
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 5, 2026 08:04

Dismissing prior approval to re-evaluate 25db0c1

Comment thread apps/mobile/src/features/home/HomeRouteScreen.tsx
@PixPMusic
PixPMusic force-pushed the pixpmusic/fix-android-tablet-header branch 2 times, most recently from 3fa612c to c96aea6 Compare August 5, 2026 08:16
Comment thread apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx Outdated
@PixPMusic
PixPMusic force-pushed the pixpmusic/fix-android-tablet-header branch from c96aea6 to 1a9de54 Compare August 5, 2026 08:21
@PixPMusic PixPMusic changed the title fix(mobile): restore Android tablet thread controls fix(mobile): restore Android tablet thread controls, clean up header Aug 5, 2026
@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 6, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 6, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 6, 2026 03:46

Dismissing prior approval to re-evaluate f3856da

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 6, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 6, 2026 03:57

Dismissing prior approval to re-evaluate ecdfdba

Comment thread apps/mobile/src/components/CompactBrandTitle.tsx
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 6, 2026
@PixPMusic
PixPMusic force-pushed the pixpmusic/fix-android-tablet-header branch from 9a05d3a to 5d5b72a Compare August 8, 2026 01:11
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 8, 2026 01:12

Dismissing prior approval to re-evaluate 5d5b72a

@PixPMusic
PixPMusic force-pushed the pixpmusic/fix-android-tablet-header branch from 5d5b72a to 1359088 Compare August 8, 2026 01:16
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 8, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1359088. Configure here.

Comment thread apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 8, 2026 01:34

Dismissing prior approval to re-evaluate 211d96b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant