fix(mobile): restore Android tablet thread controls, clean up header - #5385
fix(mobile): restore Android tablet thread controls, clean up header#5385PixPMusic wants to merge 6 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 211d96b Mobile UI fix restoring Android tablet FAB controls and simplifying header styling. Changes are self-contained platform-specific adjustments with no business logic impact, removing ~30 lines of gradient effects and consolidating header behavior. You can customize Macroscope's approvability policy. Learn more. |
4f7fc48 to
be61e0b
Compare
Dismissing prior approval to re-evaluate be61e0b
be61e0b to
73931e8
Compare
73931e8 to
25db0c1
Compare
Dismissing prior approval to re-evaluate 25db0c1
3fa612c to
c96aea6
Compare
c96aea6 to
1a9de54
Compare
Dismissing prior approval to re-evaluate f3856da
Dismissing prior approval to re-evaluate ecdfdba
9a05d3a to
5d5b72a
Compare
Dismissing prior approval to re-evaluate 5d5b72a
5d5b72a to
1359088
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1359088. Configure here.
Dismissing prior approval to re-evaluate 211d96b

What Changed
Why
Android tablets and unfolded foldables use a separate split-view sidebar once the window reaches 720dp × 600dp. That sidebar had drifted from the phone surface: it showed a hardcoded “Threads” title, a different settings icon, and no persistent way to start a task.
The new-thread screen also used padding-based keyboard avoidance while existing threads used a frame-synced sticky composer. On a foldable, the IME could cover the new-thread toolbar even though the existing-thread toolbar remained visible.
The empty split-view detail route still mounted a blank Android native header, leaving a lighter strip and divider above the otherwise uniform detail background.
This addresses the header, settings, and new-task portions of #5338. Sidebar collapse is intentionally outside this focused PR.
UI Changes
Both captures use the same deterministic dark-mode Threads fixture on an unfolded Pixel 9 Pro Fold AVD at its native 2076×2152 display size. Every “After” capture below was regenerated from the exact PR head (
1a9de543f) using the production/Alpha variant in one emulator session.Final baseline and empty-detail proof
New thread with keyboard open
Verification
pnpm --filter @t3tools/mobile typecheckgit diff --checkpixel_9_pro_foldAndroid hardware profileChecklist
Model: GPT-5.6 Sol | Harness: Codex in T3 Code
Note
Low Risk
Focused Android/iOS mobile UI and keyboard layout changes with no auth, data, or API impact; main risk is regressions on split-view navigation and IME overlap on new-thread compose.
Overview
Brings Android split-view (tablet/foldable) thread navigation in line with phone surfaces: the sidebar shows the T3 Code lockup instead of a hardcoded “Threads” title, uses the shared settings control (the Android-only header-actions file is removed), and gets the same bottom-right new task FAB via
AndroidHomeFabLayouton the persistent sidebar—with extra list bottom inset so rows clear the FAB.Split-view Home hides the empty detail pane’s native stack header on Android (
headerShown: false); leaving split view explicitly restoresheaderShown: truewhen re-applying connection-aware brand options.CompactBrandTitlegains optionalallowFontScaling(enabled for iOS nav bar rendering, disabled in the sidebar lockup).On new thread (Android), the composer toolbar moves from padding-based
KeyboardAvoidingViewtoKeyboardStickyViewso it tracks the IME like existing thread composers. The sidebar sticky header drops scroll-driven gradient wash in favor of a solid drawer background.Reviewed by Cursor Bugbot for commit 211d96b. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Restore Android tablet thread controls and clean up split-view header
ThreadNavigationSidebarinAndroidHomeFabLayoutinside AdaptiveWorkspaceLayout.tsx.CompactBrandTitle(font scaling disabled on Android) and removes the scroll-based header wash gradient from ThreadNavigationSidebar.tsx.NewTaskDraftScreenfromKeyboardAvoidingViewtoKeyboardStickyView, fixing control positioning during text input.Macroscope summarized 211d96b.