Skip to content

fix(server): interrupt turns after approval cancellation - #5429

Draft
t3-code[bot] wants to merge 2 commits into
mainfrom
t3bot/fix-approval-cancel-interrupt
Draft

fix(server): interrupt turns after approval cancellation#5429
t3-code[bot] wants to merge 2 commits into
mainfrom
t3bot/fix-approval-cancel-interrupt

Conversation

@t3-code

@t3-code t3-code Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

what changed

  • interrupt the active provider turn after a successful approval cancel response
  • keep decline scoped to the current request
  • avoid interrupting when the provider response fails

why

Cancelling an approval only answered the request, so Cursor could continue the same turn and immediately ask for more approvals.

ui changes

None.

checks

  • 47 focused ProviderCommandReactor tests
  • server typecheck
  • targeted format and lint
  • git diff --check

Model: OpenAI (API model not exposed). Harness: T3bot.

Note

Interrupt provider turn after approval cancellation in ProviderCommandReactor

  • After sending an approval response to the provider, ProviderCommandReactor now calls providerService.interruptTurn only when the decision is cancel and the response succeeded.
  • Decline decisions do not trigger an interrupt, and a failed response to the provider also skips the interrupt.
  • Three new tests cover the cancel-then-interrupt path, the decline-no-interrupt path, and the failure-no-interrupt path in ProviderCommandReactor.test.ts.
📊 Macroscope summarized 7d5341a. 1 file reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 5, 2026
Comment thread apps/server/src/orchestration/Layers/ProviderCommandReactor.ts
@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants