fix(server): interrupt turns after approval cancellation - #5429
Draft
t3-code[bot] wants to merge 2 commits into
Draft
fix(server): interrupt turns after approval cancellation#5429t3-code[bot] wants to merge 2 commits into
t3-code[bot] wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
cancelresponsedeclinescoped to the current requestwhy
Cancelling an approval only answered the request, so Cursor could continue the same turn and immediately ask for more approvals.
ui changes
None.
checks
ProviderCommandReactortestsgit diff --checkModel: OpenAI (API model not exposed). Harness: T3bot.
Note
Interrupt provider turn after approval cancellation in
ProviderCommandReactorProviderCommandReactornow callsproviderService.interruptTurnonly when the decision iscanceland the response succeeded.ProviderCommandReactor.test.ts.📊 Macroscope summarized 7d5341a. 1 file reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.