Skip to content

fix(acp): keep unknown approvals actionable - #5430

Draft
t3-code[bot] wants to merge 1 commit into
mainfrom
t3bot/fix-acp-unknown-approvals
Draft

fix(acp): keep unknown approvals actionable#5430
t3-code[bot] wants to merge 1 commit into
mainfrom
t3bot/fix-acp-unknown-approvals

Conversation

@t3-code

@t3-code t3-code Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

what changed

  • map unrecognized ACP permission kinds to dynamic_tool_call
  • preserve existing execute, read, and file-change mappings
  • verify generic requests remain actionable in the web approval list

why

Cursor and Grok can send permission kinds outside our known set. Those requests were projected as pending but omitted by the client, leaving an Approval status with no card to resolve.

ui changes

No visual styling changes. Previously hidden generic approvals now use the existing command approval card.

checks

  • 63 focused ACP and session-logic tests
  • server and web typechecks
  • targeted formatting
  • git diff --check

Model: OpenAI (API model not exposed). Harness: T3bot.

Note

Map unknown ACP permission kinds to dynamic_tool_call instead of unknown

Unrecognized ACP permission kinds previously mapped to 'unknown' in canonicalRequestTypeFromAcpKind, making those approvals non-actionable. The default case in AcpCoreRuntimeEvents.ts now returns 'dynamic_tool_call', and the AcpCanonicalRequestType alias is updated to match. On the web side, dynamic_tool_call request types are derived as requestKind: 'command' pending approvals, so they surface correctly in the UI.

Macroscope summarized 2634697.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants