fix(acp): keep unknown approvals actionable - #5430
Draft
t3-code[bot] wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
dynamic_tool_callwhy
Cursor and Grok can send permission kinds outside our known set. Those requests were projected as pending but omitted by the client, leaving an Approval status with no card to resolve.
ui changes
No visual styling changes. Previously hidden generic approvals now use the existing command approval card.
checks
git diff --checkModel: OpenAI (API model not exposed). Harness: T3bot.
Note
Map unknown ACP permission kinds to
dynamic_tool_callinstead ofunknownUnrecognized ACP permission kinds previously mapped to
'unknown'incanonicalRequestTypeFromAcpKind, making those approvals non-actionable. The default case in AcpCoreRuntimeEvents.ts now returns'dynamic_tool_call', and theAcpCanonicalRequestTypealias is updated to match. On the web side,dynamic_tool_callrequest types are derived asrequestKind: 'command'pending approvals, so they surface correctly in the UI.Macroscope summarized 2634697.