Skip to content

fix(web): update pills use readable theme foregrounds #5938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 2 commits into from
Aug 10, 2026
+5 −5
Merged

fix(web): update pills use readable theme foregrounds #5938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
102fb8d
fix(web): use foreground token for update pills
chrisdeeming Aug 10, 2026
13c0b81
fix(web): improve dark update foreground contrast
chrisdeeming Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/src/components/sidebar/SidebarProviderUpdatePill.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip";

const PROVIDER_UPDATE_PILL_STYLES = {
loading:
"bg-update-surface text-update group-has-[button.provider-update-main:hover]/provider-update:bg-update/22",
"bg-update-surface text-update-foreground group-has-[button.provider-update-main:hover]/provider-update:bg-update/22",
success:
"bg-success/12 text-success group-has-[button.provider-update-main:hover]/provider-update:bg-success/18",
warning:
Expand Down
4 changes: 2 additions & 2 deletions apps/web/src/components/sidebar/SidebarUpdatePill.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export function SidebarUpdatePill() {
)}
{visible && (
<div
className={`group/update relative flex h-7 w-full items-center rounded-lg bg-update-surface text-xs font-medium text-update ${
className={`group/update relative flex h-7 w-full items-center rounded-lg bg-update-surface text-xs font-medium text-update-foreground ${
disabled ? " cursor-not-allowed opacity-60" : ""
}`}
>
Expand Down Expand Up @@ -224,7 +224,7 @@ export function SidebarUpdatePill() {
<button
type="button"
aria-label="Dismiss update"
className="mr-1 inline-flex size-5 items-center justify-center rounded-md text-update/60 transition-colors hover:text-update"
className="mr-1 inline-flex size-5 items-center justify-center rounded-md text-update-foreground transition-colors"
onClick={() => setDismissed(true)}
>
<XIcon className="size-3.5" />
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,7 @@ html[data-mobile-composer-route-transition="true"]::view-transition-old(t3-mobil
--warning-foreground: var(--color-amber-400);
--warning-surface: color-mix(in srgb, var(--warning) 16%, transparent);
--update: var(--primary);
--update-foreground: var(--primary);
--update-foreground: var(--color-blue-400);
--update-surface: color-mix(in srgb, var(--update) 18%, transparent);
--sidebar: var(--card);
--sidebar-foreground: var(--foreground);
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/themePalette.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ const T3_CODE_DARK_THEME_COLORS: ThemeColors = {
warningForeground: "#ffb900",
warningSurface: "#312108",
update: "#366ffb",
updateForeground: "#366ffb",
updateForeground: "#51a2ff",
updateSurface: "#121c35",
accentSurface: "#141414",
accentSurfaceForeground: "#f5f5f5",
Expand Down
Loading