Skip to content

fix(web): account for Windows window controls in PR page header - #6049

Merged
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
UtkarshUsername:fix/web/pr-header-windows-wco-inset
Aug 10, 2026
Merged

fix(web): account for Windows window controls in PR page header#6049
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
UtkarshUsername:fix/web/pr-header-windows-wco-inset

Conversation

@UtkarshUsername

@UtkarshUsername UtkarshUsername commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

What Changed

The pull request page header now makes room for the Windows minimize, maximize, and close buttons.

Added WCO-aware right padding to the PR header, using the same --workspace-native-controls-inset mechanism the settings page header and the chat view already use. The padding is applied only while the right panel is closed, since that's the only state where the column spans the full window width and actually reaches under the OS buttons.

Why

On Windows, window control buttons are drawn by the OS over the top-right of the window, and the PR header was the one surface that didn't reserve space for them, so the refresh button and the right sidebar toggle were rendering underneath them and colliding.

UI Changes

Before:
image

After:
image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes

Note

Low Risk
Conditional CSS on the PR list header only; no auth, data, or API changes.

Overview
On Windows, the pull requests list header could sit under the native minimize/maximize/close buttons when the right panel is closed and the column is full width.

PullRequestsColumn now receives rightPanelOpen from the route. The topbar applies wco:pr-[var(--workspace-native-controls-inset)] only when the panel is closed—the same inset chat and settings already use. When the panel is open, the list column no longer reaches the window edge, so that padding is skipped and the floating panel controls keep handling the corner.

Reviewed by Cursor Bugbot for commit a131dda. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Account for Windows window controls in the pull requests page header

When the right panel is closed, the PullRequestsColumn header adds right padding equal to --workspace-native-controls-inset via the wco:pr-[var(--workspace-native-controls-inset)] class to avoid overlap with Windows window controls. When the right panel is open, the padding is omitted since the panel already fills that space.

Macroscope summarized a131dda.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5637dd7c-3f7e-4de6-b454-9152eff5b440

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Aug 10, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved a131dda

This is a minor UI fix that adds CSS padding for Windows window controls when the right panel is closed. The change is purely visual, follows existing patterns in the codebase, and has no runtime behavior impact.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge merged commit a7b0366 into pingdotgg:main Aug 10, 2026
17 checks passed
@UtkarshUsername
UtkarshUsername deleted the fix/web/pr-header-windows-wco-inset branch August 10, 2026 20:10
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 10, 2026
## What's Changed
* fix(ci): extend release publish timeout by @t3-code[bot] in pingdotgg/t3code#6034
* Allow Android tablets to rotate by @juliusmarminge in pingdotgg/t3code#5613
* fix(web): account for Windows window controls in PR page header by @UtkarshUsername in pingdotgg/t3code#6049


**Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260810.1061...v0.0.34-nightly.20260810.1062

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260810.1062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants