fix(web): account for Windows window controls in PR page header - #6049
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved a131dda This is a minor UI fix that adds CSS padding for Windows window controls when the right panel is closed. The change is purely visual, follows existing patterns in the codebase, and has no runtime behavior impact. You can customize Macroscope's approvability policy. Learn more. |
## What's Changed * fix(ci): extend release publish timeout by @t3-code[bot] in pingdotgg/t3code#6034 * Allow Android tablets to rotate by @juliusmarminge in pingdotgg/t3code#5613 * fix(web): account for Windows window controls in PR page header by @UtkarshUsername in pingdotgg/t3code#6049 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260810.1061...v0.0.34-nightly.20260810.1062 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260810.1062
What Changed
The pull request page header now makes room for the Windows minimize, maximize, and close buttons.
Added WCO-aware right padding to the PR header, using the same --workspace-native-controls-inset mechanism the settings page header and the chat view already use. The padding is applied only while the right panel is closed, since that's the only state where the column spans the full window width and actually reaches under the OS buttons.
Why
On Windows, window control buttons are drawn by the OS over the top-right of the window, and the PR header was the one surface that didn't reserve space for them, so the refresh button and the right sidebar toggle were rendering underneath them and colliding.
UI Changes
Before:

After:

Checklist
Note
Low Risk
Conditional CSS on the PR list header only; no auth, data, or API changes.
Overview
On Windows, the pull requests list header could sit under the native minimize/maximize/close buttons when the right panel is closed and the column is full width.
PullRequestsColumnnow receivesrightPanelOpenfrom the route. The topbar applieswco:pr-[var(--workspace-native-controls-inset)]only when the panel is closed—the same inset chat and settings already use. When the panel is open, the list column no longer reaches the window edge, so that padding is skipped and the floating panel controls keep handling the corner.Reviewed by Cursor Bugbot for commit a131dda. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Account for Windows window controls in the pull requests page header
When the right panel is closed, the
PullRequestsColumnheader adds right padding equal to--workspace-native-controls-insetvia thewco:pr-[var(--workspace-native-controls-inset)]class to avoid overlap with Windows window controls. When the right panel is open, the padding is omitted since the panel already fills that space.Macroscope summarized a131dda.