Skip to content

Cleanup Codes related to FileDB#5786

Merged
khanhtc1202 merged 1 commit into
pipe-cd:masterfrom
Okabe-Junya:fix-5652
Jul 22, 2025
Merged

Cleanup Codes related to FileDB#5786
khanhtc1202 merged 1 commit into
pipe-cd:masterfrom
Okabe-Junya:fix-5652

Conversation

@Okabe-Junya
Copy link
Copy Markdown
Member

@Okabe-Junya Okabe-Junya commented Apr 28, 2025

What this PR does:

Remove all FileDB-related code from the codebase

Why we need it:

See #5652

Which issue(s) this PR fixes:

Ref. #5652
(Not close, since I haven't cleanup-ed docs yet / I haven't decided how to migrate yet)

Note:

Per PipeCD’s maintenance and release policy, you’re welcome to target this PR at a different branch or leave it unmerged for a while.
I respect the maintenance team’s policy :)

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change: Users will no longer be able to configure FileDB as PipeCD datastore.
  • How to migrate (if breaking change):

Copy link
Copy Markdown
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202
Copy link
Copy Markdown
Member

Hi @Okabe-Junya Thanks for the commit 👍
This feature deprecation issue could be a bit more complicated than the removed code in this PR, so we added hold label for now. If you feel interest on this issue, please join the public dev mtg or CNCF #pipecd channel for further discussion.
We really appreciate your interest, thank you 😁

@Okabe-Junya
Copy link
Copy Markdown
Member Author

Thank you - I understand how complex this issue can become, and I will fully respect the team’s opinions.

Thanks also for sharing the Slack channel and meeting details; I’ll check them out :)

@t-kikuc
Copy link
Copy Markdown
Member

t-kikuc commented May 22, 2025

@khanhtc1202
Let's explain the "bit more complicated" parts, or merge this PR (fixes -> part of) and do it as a new PR 👍

@khanhtc1202
Copy link
Copy Markdown
Member

Sure, I will explain this on issue 👀 Then we can have check list over there, and discard how we process this issue👌

@Warashi Warashi requested a review from a team as a code owner May 29, 2025 03:52
@Warashi
Copy link
Copy Markdown
Member

Warashi commented May 29, 2025

Sorry, we updated the CI and branch protection rules.
I updated the branch of this PR by pushing the Update branch button, which is the GitHub feature.
Please let me know if you see any unexpected behavior.

@Okabe-Junya
Copy link
Copy Markdown
Member Author

It appears that CI will not run unless one of the maintainers presses the approve to run button

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
@Okabe-Junya
Copy link
Copy Markdown
Member Author

@t-kikuc @khanhtc1202

I'm sorry for the reconfirmation,

Where else was the code that needs cleaning up in this PR to move forward?
I apologize for the inconvenience and thank you in advance!

@khanhtc1202
Copy link
Copy Markdown
Member

Thanks @Okabe-Junya, I think we can merge this PR to bootstrap the FileDB removal. Other tasks to check will be managed here #5652 (comment)

Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you!

@khanhtc1202 khanhtc1202 merged commit 449fcdf into pipe-cd:master Jul 22, 2025
76 checks passed
@Okabe-Junya Okabe-Junya deleted the fix-5652 branch July 22, 2025 05:21
hongky-1994 pushed a commit that referenced this pull request Jul 30, 2025
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants