Remove deprecated field from Deployment#5809
Conversation
Signed-off-by: sagnik3788 <sagnikdas5432@gmail.com>
|
@sagnik3788 |
Signed-off-by: sagnik3788 <sagnikdas5432@gmail.com>
Signed-off-by: sagnik3788 <sagnikdas5432@gmail.com>
|
I will fix these |
|
@sagnik3788 Please fix lint and test, and use |
Signed-off-by: sagnik3788 <sagnikdas5432@gmail.com>
Signed-off-by: sagnik3788 <sagnikdas5432@gmail.com>
Warashi
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
I commented on nits.
|
@sagnik3788 And please fix the conflict 🙇 It's due to other PRs. |
Signed-off-by: sagnik3788 <sagnikdas5432@gmail.com>
Signed-off-by: Sagnik Das <116512372+sagnik3788@users.noreply.github.com>
Signed-off-by: sagnik3788 <sagnikdas5432@gmail.com>
|
Sorry, we updated the CI and branch protection rules. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5809 +/- ##
==========================================
+ Coverage 27.85% 36.28% +8.43%
==========================================
Files 519 30 -489
Lines 55793 3296 -52497
==========================================
- Hits 15539 1196 -14343
+ Misses 39070 2034 -37036
+ Partials 1184 66 -1118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What this PR does:
as title
Why we need it:
version field was already marked as deprecated and is no longer in use
Which issue(s) this PR fixes:
Fixes #5061