Skip to content

Remove deprecated field from Deployment#5809

Merged
khanhtc1202 merged 10 commits into
pipe-cd:masterfrom
sagnik3788:test
Jun 17, 2025
Merged

Remove deprecated field from Deployment#5809
khanhtc1202 merged 10 commits into
pipe-cd:masterfrom
sagnik3788:test

Conversation

@sagnik3788
Copy link
Copy Markdown
Member

What this PR does:
as title

Why we need it:
version field was already marked as deprecated and is no longer in use

Which issue(s) this PR fixes:

Fixes #5061

Signed-off-by: sagnik3788 <sagnikdas5432@gmail.com>
@t-kikuc
Copy link
Copy Markdown
Member

t-kikuc commented May 12, 2025

Signed-off-by: sagnik3788 <sagnikdas5432@gmail.com>
Signed-off-by: sagnik3788 <sagnikdas5432@gmail.com>
@sagnik3788
Copy link
Copy Markdown
Member Author

I will fix these

@khanhtc1202 khanhtc1202 changed the title remove deprecated field from Deployment Remove deprecated field from Deployment May 15, 2025
@t-kikuc
Copy link
Copy Markdown
Member

t-kikuc commented May 16, 2025

@sagnik3788 Please fix lint and test, and use make gen/code

Signed-off-by: sagnik3788 <sagnikdas5432@gmail.com>
Comment thread pkg/app/pipedv1/trigger/deployment.go
Signed-off-by: sagnik3788 <sagnikdas5432@gmail.com>
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

I commented on nits.

Comment thread pkg/datastore/deploymentstore.go
@t-kikuc
Copy link
Copy Markdown
Member

t-kikuc commented May 22, 2025

@sagnik3788 And please fix the conflict 🙇 It's due to other PRs.

Signed-off-by: sagnik3788 <sagnikdas5432@gmail.com>
@sagnik3788 sagnik3788 requested review from a team as code owners May 24, 2025 05:13
@sagnik3788 sagnik3788 requested review from Warashi and hongky-1994 May 24, 2025 05:13
@sagnik3788 sagnik3788 requested a review from t-kikuc May 24, 2025 05:13
Signed-off-by: Sagnik Das <116512372+sagnik3788@users.noreply.github.com>
t-kikuc
t-kikuc previously approved these changes May 26, 2025
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Signed-off-by: sagnik3788 <sagnikdas5432@gmail.com>
@Warashi
Copy link
Copy Markdown
Member

Warashi commented May 29, 2025

Sorry, we updated the CI and branch protection rules.
I updated the branch of this PR by pushing the Update branch button, which is the GitHub feature.
Please let me know if you see any unexpected behavior.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.28%. Comparing base (44a0c00) to head (7bf88c4).
Report is 46 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5809      +/-   ##
==========================================
+ Coverage   27.85%   36.28%   +8.43%     
==========================================
  Files         519       30     -489     
  Lines       55793     3296   -52497     
==========================================
- Hits        15539     1196   -14343     
+ Misses      39070     2034   -37036     
+ Partials     1184       66    -1118     
Flag Coverage Δ
. ?
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes ?
.-pkg-app-pipedv1-plugin-kubernetes_multicluster ?
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 49.25% <ø> (ø)
.-tool-actions-gh-release 19.58% <ø> (ø)
.-tool-actions-plan-preview 23.22% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🚀

@khanhtc1202 khanhtc1202 merged commit 40a203e into pipe-cd:master Jun 17, 2025
39 checks passed
@sagnik3788 sagnik3788 deleted the test branch June 17, 2025 16:56
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated model.Deployment.version

4 participants