[K8s Plugin] Add helper functions for canary stage#5892
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5892 +/- ##
==========================================
+ Coverage 27.89% 27.99% +0.10%
==========================================
Files 519 520 +1
Lines 55923 56070 +147
==========================================
+ Hits 15600 15699 +99
- Misses 39125 39158 +33
- Partials 1198 1213 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ffjlabo
changed the title
ffjlabo
force-pushed
the
add-helper-functions-for-canary-stage
branch
from
fccf6a5 to
77f23ed
Compare
|
Sorry, we updated the CI and branch protection rules. |
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
ffjlabo
force-pushed
the
add-helper-functions-for-canary-stage
branch
from
8fb033d to
396d17e
Compare
t-kikuc
left a comment
t-kikuc
left a comment
There was a problem hiding this comment.
Almost LGTM
I got it, testcases are also copied from pipedv0.
| ) | ||
|
|
||
| func Test_findConfigMapManifests(t *testing.T) { | ||
| tests := []struct { |
There was a problem hiding this comment.
t.Parallel() is possible? (if not, please ignore)
|
|
||
| "github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/kubernetes/config" | ||
| "github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/kubernetes/provider" | ||
| "github.com/pipe-cd/pipecd/pkg/yamlprocessor" |
There was a problem hiding this comment.
Should this yamlprocessor package be part of the SDK as well? 🤔
There was a problem hiding this comment.
Thanks, now that you mention it, it might be true.
IMO, it should stay as is for now.
It seems this package is mainly for piped logic and is used only for the canary stage as executor logic for now.
WDYT?
There was a problem hiding this comment.
IMO, official plugins should not depend on pipe-cd/pipecd/pkg/... as much as possible because it causes dependency chaos.
However, I have no idea of the new place for now 😅 (internal/ dir??)
There was a problem hiding this comment.
I see.
@khanhtc1202 @t-kikuc
So I think there are two patterns for now. Which is better for you?
- Add same package to SDK
- Add same package to k8s plugin
IMO, 2 is better because it is not expected to be used for other executors for now.
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
4 participants
What this PR does:
Added 4 functions to use in the canary stage logic from pipedv0.
Why we need it:
To support k8s pipeline sync in the plugin
Which issue(s) this PR fixes:
Part of #5764
Does this PR introduce a user-facing change?: