Rename completed job to avoid confusing behavior#5895
Merged
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5895 +/- ##
==========================================
+ Coverage 27.84% 27.85% +0.01%
==========================================
Files 519 519
Lines 55793 55793
==========================================
+ Hits 15533 15539 +6
+ Misses 39076 39070 -6
Partials 1184 1184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t-kikuc
approved these changes
May 29, 2025
ffjlabo
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Rename GitHub Action Job
Why we need it:
We set
go-completedas the required check, but this condition passes at one of the lint/test passes and the other is not running yet.This behavior is not expected; we want to set both of the lint/test as required.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: