Skip to content

add more fields from deployment proto to deployment model for scriptrun plugin#5902

Merged
t-kikuc merged 1 commit into
pipe-cd:masterfrom
hiep-tk:scriptrun
Jun 2, 2025
Merged

add more fields from deployment proto to deployment model for scriptrun plugin#5902
t-kikuc merged 1 commit into
pipe-cd:masterfrom
hiep-tk:scriptrun

Conversation

@hiep-tk
Copy link
Copy Markdown
Contributor

@hiep-tk hiep-tk commented May 30, 2025

What this PR does: add repositoryURL, summary, and labels available from deployment proto to deployment model

Why we need it: scriptrun env tagging utilize this. need to be a separate commit because we need to have a new concrete piped-plugin-sdk-go version to point to from the plugin

Which issue(s) this PR fixes: Part of #5901

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

…un plugin

Signed-off-by: hiep-tk <hiep.trinhkhanh0466@gmail.com>
@hiep-tk hiep-tk requested a review from a team as a code owner May 30, 2025 03:52
@github-actions
Copy link
Copy Markdown
Contributor

@hiep-tk
Thank you for your contribution! We look forward to seeing more from you.
Please run the make check command to ensure your changes will pass the CI.
After successfully running the command on your local machine, the instructions will be printed out.
Please follow them to commit your changes.
If the check has not passed, please fix the issues and push the changes to your branch.
Then, please run the make check command again to ensure the issues are fixed.

@t-kikuc
Copy link
Copy Markdown
Member

t-kikuc commented May 30, 2025

@hiep-tk
Thank you, please

  1. Make a to-do list on Implement SCRIPT_RUN Stage Plugin #5901 to track what each PR does
  2. Add Part of #5901 to the Which issue ... section of this PR in order to link this PR to the issue

Copy link
Copy Markdown
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go!

@t-kikuc t-kikuc enabled auto-merge (squash) May 30, 2025 04:11
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be late. LGTM

@t-kikuc t-kikuc merged commit 6c554c8 into pipe-cd:master Jun 2, 2025
39 checks passed
@github-actions github-actions Bot mentioned this pull request Jun 2, 2025
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants