Skip to content

Remove check workflow & improve DCO check script#5904

Merged
Warashi merged 2 commits into
masterfrom
remove-check-workflow
May 30, 2025
Merged

Remove check workflow & improve DCO check script#5904
Warashi merged 2 commits into
masterfrom
remove-check-workflow

Conversation

@Warashi
Copy link
Copy Markdown
Member

@Warashi Warashi commented May 30, 2025

What this PR does:

  • Remove non-maintainer check workflow
  • Ignore merge commit in the check/dco

Why we need it:

  • It's a bit complex compared to its benefit
  • merge commits may lack sign-off, and it's allowed

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Warashi added 2 commits May 30, 2025 15:45
This workflow is a bit complex compared to it's purpose

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.89%. Comparing base (29e3ccf) to head (9424489).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5904      +/-   ##
==========================================
- Coverage   27.93%   27.89%   -0.05%     
==========================================
  Files         516      519       +3     
  Lines       55450    55923     +473     
==========================================
+ Hits        15492    15600     +108     
- Misses      38767    39125     +358     
- Partials     1191     1198       +7     
Flag Coverage Δ
. 23.75% <ø> (ø)
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 63.32% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 64.93% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 49.25% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 22.83% <ø> (?)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Warashi Warashi changed the title Remove check workflow Remove check workflow & improve dco check script May 30, 2025
@Warashi Warashi changed the title Remove check workflow & improve dco check script Remove check workflow & improve DCO check script May 30, 2025
@Warashi Warashi marked this pull request as ready for review May 30, 2025 06:56
@Warashi Warashi requested a review from a team as a code owner May 30, 2025 06:56
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@Warashi Warashi enabled auto-merge (squash) May 30, 2025 07:00
@Warashi Warashi merged commit 9be5674 into master May 30, 2025
41 of 42 checks passed
@Warashi Warashi deleted the remove-check-workflow branch May 30, 2025 09:01
@github-actions github-actions Bot mentioned this pull request Jun 2, 2025
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants