Skip to content

[K8s plugin] implement K8S_BASELINE_CLEAN stage#5913

Merged
Warashi merged 6 commits into
masterfrom
k8s-plugin-baseline-clean
Jun 3, 2025
Merged

[K8s plugin] implement K8S_BASELINE_CLEAN stage#5913
Warashi merged 6 commits into
masterfrom
k8s-plugin-baseline-clean

Conversation

@Warashi
Copy link
Copy Markdown
Member

@Warashi Warashi commented Jun 3, 2025

What this PR does:

  • fixed deleteVariantResources's argument
  • implement K8S_BASELINE_CLEAN and its test

Why we need it:

to support pipeline sync with k8s plugin

Which issue(s) this PR fixes:

Part of #5764

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Warashi added 6 commits June 3, 2025 15:43
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 62.79070% with 16 lines in your changes missing coverage. Please review.

Project coverage is 28.08%. Comparing base (1ac2006) to head (541982b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...p/pipedv1/plugin/kubernetes/deployment/baseline.go 60.97% 12 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5913      +/-   ##
==========================================
+ Coverage   28.02%   28.08%   +0.06%     
==========================================
  Files         520      520              
  Lines       56134    56172      +38     
==========================================
+ Hits        15729    15775      +46     
+ Misses      39190    39176      -14     
- Partials     1215     1221       +6     
Flag Coverage Δ
. 23.74% <ø> (ø)
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 63.84% <62.79%> (+0.81%) ⬆️
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 64.93% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 49.33% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Warashi Warashi marked this pull request as ready for review June 3, 2025 07:39
@Warashi Warashi requested a review from a team as a code owner June 3, 2025 07:39
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Warashi Warashi merged commit d667a1c into master Jun 3, 2025
40 checks passed
@Warashi Warashi deleted the k8s-plugin-baseline-clean branch June 3, 2025 08:18
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants