Skip to content

Implement K8S_CANARY_CLEAN stage#5918

Merged
ffjlabo merged 1 commit into
masterfrom
implement-k8s-canary-clean-stage
Jun 6, 2025
Merged

Implement K8S_CANARY_CLEAN stage#5918
ffjlabo merged 1 commit into
masterfrom
implement-k8s-canary-clean-stage

Conversation

@ffjlabo
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo commented Jun 5, 2025

What this PR does:

Implemented K8S_CANARY_CLEAN and its test

Why we need it:

We want to support k8s plugin pipeline sync.

Which issue(s) this PR fixes:

Part of #5764

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 60.97561% with 16 lines in your changes missing coverage. Please review.

Project coverage is 28.42%. Comparing base (db8db2f) to head (dfc5520).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...app/pipedv1/plugin/kubernetes/deployment/canary.go 60.97% 12 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5918      +/-   ##
==========================================
+ Coverage   28.39%   28.42%   +0.02%     
==========================================
  Files         520      520              
  Lines       56343    56381      +38     
==========================================
+ Hits        15997    16024      +27     
- Misses      39086    39093       +7     
- Partials     1260     1264       +4     
Flag Coverage Δ
. 23.74% <ø> (ø)
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 65.80% <60.97%> (+0.06%) ⬆️
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 49.33% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ffjlabo ffjlabo force-pushed the implement-k8s-canary-clean-stage branch from 929375a to d1ff545 Compare June 5, 2025 07:50
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@ffjlabo ffjlabo force-pushed the implement-k8s-canary-clean-stage branch from d1ff545 to dfc5520 Compare June 5, 2025 08:19
@ffjlabo ffjlabo marked this pull request as ready for review June 5, 2025 08:28
@ffjlabo ffjlabo requested a review from a team as a code owner June 5, 2025 08:28
@ffjlabo ffjlabo enabled auto-merge (squash) June 5, 2025 08:29
@ffjlabo ffjlabo merged commit fbb422d into master Jun 6, 2025
40 checks passed
@ffjlabo ffjlabo deleted the implement-k8s-canary-clean-stage branch June 6, 2025 00:19
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants