Skip to content

[K8s plugin] Delete baseline/canary variant resources on K8S_ROLLBACK stage#5919

Merged
Warashi merged 4 commits into
masterfrom
k8s-plugin-rollback-pruning
Jun 6, 2025
Merged

[K8s plugin] Delete baseline/canary variant resources on K8S_ROLLBACK stage#5919
Warashi merged 4 commits into
masterfrom
k8s-plugin-rollback-pruning

Conversation

@Warashi
Copy link
Copy Markdown
Member

@Warashi Warashi commented Jun 6, 2025

What this PR does:

as title

Why we need it:

It's supported in pipedv0, so we want to support it in the plugin, also.

Which issue(s) this PR fixes:

Part of #5764

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Warashi added 4 commits June 6, 2025 10:14
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 57.69231% with 11 lines in your changes missing coverage. Please review.

Project coverage is 28.46%. Comparing base (fbb422d) to head (163e523).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...p/pipedv1/plugin/kubernetes/deployment/rollback.go 57.69% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5919      +/-   ##
==========================================
+ Coverage   28.42%   28.46%   +0.04%     
==========================================
  Files         520      520              
  Lines       56381    56405      +24     
==========================================
+ Hits        16024    16058      +34     
+ Misses      39093    39081      -12     
- Partials     1264     1266       +2     
Flag Coverage Δ
. 23.74% <ø> (ø)
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <57.69%> (+0.62%) ⬆️
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 49.33% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Warashi Warashi marked this pull request as ready for review June 6, 2025 02:05
@Warashi Warashi requested a review from a team as a code owner June 6, 2025 02:05
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi merged commit 38b047b into master Jun 6, 2025
40 checks passed
@Warashi Warashi deleted the k8s-plugin-rollback-pruning branch June 6, 2025 02:44
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants