Skip to content

Fix nil pointer dereference error on spec.plugins config on app config not set#5922

Merged
Warashi merged 1 commit into
masterfrom
sdk-set-zero-value-for-application-spec
Jun 6, 2025
Merged

Fix nil pointer dereference error on spec.plugins config on app config not set#5922
Warashi merged 1 commit into
masterfrom
sdk-set-zero-value-for-application-spec

Conversation

@Warashi
Copy link
Copy Markdown
Member

@Warashi Warashi commented Jun 6, 2025

What this PR does:

as title

Why we need it:

for safe execution

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

…dereference

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@Warashi Warashi marked this pull request as ready for review June 6, 2025 08:44
@Warashi Warashi requested a review from a team as a code owner June 6, 2025 08:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.47%. Comparing base (fbb422d) to head (237cf01).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5922      +/-   ##
==========================================
+ Coverage   28.42%   28.47%   +0.05%     
==========================================
  Files         520      520              
  Lines       56381    56407      +26     
==========================================
+ Hits        16024    16060      +36     
+ Misses      39093    39081      -12     
- Partials     1264     1266       +2     
Flag Coverage Δ
. 23.74% <ø> (ø)
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <ø> (+0.62%) ⬆️
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 49.39% <100.00%> (+0.05%) ⬆️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t-kikuc t-kikuc enabled auto-merge (squash) June 6, 2025 08:45
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@khanhtc1202 khanhtc1202 changed the title Set the Spec to the zero value of the spec type to avoid nil pointer dereference Fix nil pointer dereference error on spec.plugins config not set Jun 6, 2025
@khanhtc1202 khanhtc1202 changed the title Fix nil pointer dereference error on spec.plugins config not set Fix nil pointer dereference error on spec.plugins config on app config not set Jun 6, 2025
@Warashi Warashi disabled auto-merge June 6, 2025 08:49
@Warashi Warashi enabled auto-merge (squash) June 6, 2025 08:49
@Warashi Warashi merged commit 3e331fd into master Jun 6, 2025
40 checks passed
@Warashi Warashi deleted the sdk-set-zero-value-for-application-spec branch June 6, 2025 08:51
@t-kikuc t-kikuc added area/plugin-sdk piped-plugin-sdk and removed area/sdk-plugins labels Jun 6, 2025
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants