Fix the build quick sync stages method to return an empty response#5926
Merged
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
ffjlabo
previously approved these changes
Jun 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5926 +/- ##
==========================================
+ Coverage 28.42% 28.45% +0.03%
==========================================
Files 520 516 -4
Lines 56381 56301 -80
==========================================
- Hits 16024 16023 -1
+ Misses 39093 39012 -81
- Partials 1264 1266 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khanhtc1202
reviewed
Jun 6, 2025
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
t-kikuc
previously approved these changes
Jun 6, 2025
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
t-kikuc
previously approved these changes
Jun 6, 2025
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
t-kikuc
approved these changes
Jun 6, 2025
khanhtc1202
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
The stage plugins don't support quick sync stages, so it's enough to just return an empty response.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: