Skip to content

Deprecate ArtifactVersion.kind#5939

Merged
t-kikuc merged 2 commits into
masterfrom
artifact-kind-delete
Jun 11, 2025
Merged

Deprecate ArtifactVersion.kind#5939
t-kikuc merged 2 commits into
masterfrom
artifact-kind-delete

Conversation

@t-kikuc
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc commented Jun 11, 2025

What this PR does:

  • removed sdk.ArtifactVersion.Kind
  • deprecate model.ArtifactVersion.kind (not deleted)

After merging this PR, we need to update the official plugins.

Let's delete model.ArtifactVersion.kind later. For now, we need it for backward compatibility.

Why we need it:

  • to clean unused kind from the SDK

Which issue(s) this PR fixes:

Fixes https://github.com/pipe-cd/piped-plugin-sdk-go/issues/3

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

t-kikuc added 2 commits June 11, 2025 15:45
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc requested a review from a team as a code owner June 11, 2025 06:51
@github-actions github-actions Bot added area/go area/plugin-sdk piped-plugin-sdk labels Jun 11, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.46%. Comparing base (d73300d) to head (e76df38).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5939      +/-   ##
==========================================
- Coverage   28.47%   28.46%   -0.01%     
==========================================
  Files         520      520              
  Lines       56415    56402      -13     
==========================================
- Hits        16063    16056       -7     
+ Misses      39086    39080       -6     
  Partials     1266     1266              
Flag Coverage Δ
. 23.76% <ø> (+0.01%) ⬆️
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 48.86% <ø> (-0.37%) ⬇️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc enabled auto-merge (squash) June 11, 2025 06:53
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@t-kikuc t-kikuc merged commit 275a1e1 into master Jun 11, 2025
40 checks passed
@t-kikuc t-kikuc deleted the artifact-kind-delete branch June 11, 2025 10:12
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove hard-corded ArtifactKinds

3 participants