Fix README-usage#5944
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5944 +/- ##
==========================================
- Coverage 28.49% 28.48% -0.02%
==========================================
Files 520 520
Lines 56436 56436
==========================================
- Hits 16082 16076 -6
- Misses 39087 39093 +6
Partials 1267 1267
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| # Update the workload of PRIMARY variant to the new version. | ||
| - name: K8S_PRIMARY_ROLLOUT | ||
| # Destroy all workloads of CANARY variant. | ||
| - name: K8S_CANARY_CLEAN |
There was a problem hiding this comment.
[ASK]
Is plugins.kubernetes necessary or not for the k8s plugin?
I think nil plugins won't cause an error, but I don't know much about the k8s plugin.
There was a problem hiding this comment.
If necessary, let's add like this:
| - name: K8S_CANARY_CLEAN | |
| - name: K8S_CANARY_CLEAN | |
| plugins: | |
| kubernetes: | |
| .... # See k8s plugin readme for details |
There was a problem hiding this comment.
For k8s plugin, the plugin config is not necesarry.
Then the plugin works with the default configuration.
t-kikuc
left a comment
t-kikuc
left a comment
There was a problem hiding this comment.
Go!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
ffjlabo
force-pushed
the
fix-readme-usage
branch
from
993824f to
835c665
Compare
4 participants
What this PR does:
Described the example k8s application with pipedv1.
Why we need it:
Which issue(s) this PR fixes:
Part of #5872
Does this PR introduce a user-facing change?: