Skip to content

Add index validation of buildPipelineSyncStages in planner#5946

Merged
t-kikuc merged 6 commits into
masterfrom
plugin/indexes-validation
Jun 12, 2025
Merged

Add index validation of buildPipelineSyncStages in planner#5946
t-kikuc merged 6 commits into
masterfrom
plugin/indexes-validation

Conversation

@t-kikuc
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc commented Jun 12, 2025

What this PR does:

  • Add index validations for duplication and range.
  • Add the API spec comments in api.proto and the SDK

Why we need it:

  • To prevent errors in the scheduler.
  • To make the rollback order determinate
  • To keep the rollback spec simple

Which issue(s) this PR fixes:

Part of #5259

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

t-kikuc added 4 commits June 12, 2025 11:54
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc requested a review from a team as a code owner June 12, 2025 03:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.49%. Comparing base (275a1e1) to head (221d001).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/controller/planner.go 85.71% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5946      +/-   ##
==========================================
+ Coverage   28.46%   28.49%   +0.03%     
==========================================
  Files         520      520              
  Lines       56402    56438      +36     
==========================================
+ Hits        16056    16084      +28     
- Misses      39080    39087       +7     
- Partials     1266     1267       +1     
Flag Coverage Δ
. 23.80% <85.71%> (+0.04%) ⬆️
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 48.86% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t-kikuc t-kikuc enabled auto-merge (squash) June 12, 2025 03:49
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
khanhtc1202
khanhtc1202 previously approved these changes Jun 12, 2025
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc merged commit 19aed96 into master Jun 12, 2025
40 checks passed
@t-kikuc t-kikuc deleted the plugin/indexes-validation branch June 12, 2025 05:18
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants