Skip to content

[Stage Plugins] Report stage commands as handled after the stage finished#5967

Merged
t-kikuc merged 16 commits into
masterfrom
plugin/commandstore/report
Jul 2, 2025
Merged

[Stage Plugins] Report stage commands as handled after the stage finished#5967
t-kikuc merged 16 commits into
masterfrom
plugin/commandstore/report

Conversation

@t-kikuc
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc commented Jun 24, 2025

What this PR does:

  • as title

Why we need it:

  • To suppress a too large response in apiClient.ListUnhandledCommands()

Which issue(s) this PR fixes:

Part of #5367

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
…ler,pipedapi

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 28.16%. Comparing base (c52b419) to head (e8e6f20).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/apistore/commandstore/store.go 0.00% 17 Missing ⚠️
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 3 Missing ⚠️
pkg/app/pipedv1/controller/scheduler.go 0.00% 3 Missing ⚠️
pkg/app/pipedv1/controller/controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5967   +/-   ##
=======================================
  Coverage   28.16%   28.16%           
=======================================
  Files         518      516    -2     
  Lines       55916    55917    +1     
=======================================
+ Hits        15748    15751    +3     
+ Misses      38916    38914    -2     
  Partials     1252     1252           
Flag Coverage Δ
. 23.22% <0.00%> (+<0.01%) ⬆️
.-pkg-app-pipedv1-plugin-example ?
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.89% <ø> (-0.08%) ⬇️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc changed the title Report stage commands as handled after the stage finished [Stage Plugins] Report stage commands as handled after the stage finished Jul 1, 2025
@t-kikuc t-kikuc enabled auto-merge (squash) July 1, 2025 01:58
t-kikuc added 2 commits July 1, 2025 11:14
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc merged commit 041eeb4 into master Jul 2, 2025
37 of 38 checks passed
@t-kikuc t-kikuc deleted the plugin/commandstore/report branch July 2, 2025 06:20
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants