Skip to content

[Plugins] Replace configv1 unit types with SDK unit types#5969

Merged
Warashi merged 5 commits into
masterfrom
k8s-plugin-remove-configv1
Jun 25, 2025
Merged

[Plugins] Replace configv1 unit types with SDK unit types#5969
Warashi merged 5 commits into
masterfrom
k8s-plugin-remove-configv1

Conversation

@Warashi
Copy link
Copy Markdown
Member

@Warashi Warashi commented Jun 25, 2025

What this PR does:

as title

Why we need it:

We don't want to import pkg/configv1 from plugins

Which issue(s) this PR fixes:

Follows #5959

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Warashi added 4 commits June 25, 2025 10:09
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.15%. Comparing base (c0e822f) to head (c9339ee).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5969   +/-   ##
=======================================
  Coverage   28.15%   28.15%           
=======================================
  Files         518      518           
  Lines       55910    55910           
=======================================
  Hits        15744    15744           
  Misses      38914    38914           
  Partials     1252     1252           
Flag Coverage Δ
. 23.22% <ø> (ø)
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.89% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Warashi Warashi enabled auto-merge (squash) June 25, 2025 01:24
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Warashi Warashi merged commit 6eb415a into master Jun 25, 2025
40 checks passed
@Warashi Warashi deleted the k8s-plugin-remove-configv1 branch June 25, 2025 07:39
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants