scriptrun base and planning#5990
Merged
Merged
Conversation
t-kikuc
reviewed
Jul 3, 2025
| stageScriptRunRollback = "SCRIPT_RUN_ROLLBACK" | ||
| ) | ||
|
|
||
| type ContextInfo struct { |
Member
There was a problem hiding this comment.
This is not related to this PR. Let's add in another PR.
| }, nil | ||
| } | ||
|
|
||
| func (p *plugin) FetchDefinedStages() []string { |
t-kikuc
reviewed
Jul 3, 2025
|
|
||
| func TestBuildPipelineSyncStages(t *testing.T) { | ||
| p := &plugin{} | ||
| ctx := context.Background() |
| name string | ||
| input *sdk.BuildPipelineSyncStagesInput | ||
| expected *sdk.BuildPipelineSyncStagesResponse | ||
| expectErr bool |
t-kikuc
reviewed
Jul 8, 2025
| // the command(s) to run | ||
| Run string `json:"run,omitempty"` | ||
| // timeout limit for this stage | ||
| Timeout config.Duration `json:"timeout,omitempty" default:"6h"` |
Member
There was a problem hiding this comment.
Use pkg/plugin/sdk/unit/duration.go instead. we created it recently.
Signed-off-by: hiep-tk <hiep.trinhkhanh0466@gmail.com>
Signed-off-by: hiep-tk <hiep.trinhkhanh0466@gmail.com>
Signed-off-by: hiep-tk <hiep.trinhkhanh0466@gmail.com>
Merged
This was referenced Jul 31, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: Scriptrun base and planning phase
Why we need it: scriptrun stage migration to plugin
Which issue(s) this PR fixes: Part of #5901
Fixes #
Does this PR introduce a user-facing change?: