Skip to content

Init Terraform plugin#5993

Merged
t-kikuc merged 8 commits into
masterfrom
plugin/terraform/team-sync
Jul 3, 2025
Merged

Init Terraform plugin#5993
t-kikuc merged 8 commits into
masterfrom
plugin/terraform/team-sync

Conversation

@t-kikuc
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc commented Jul 3, 2025

What this PR does:

init the plugin without DetermineVersions, ExecuteStage

Note: Deleted the Sync stage. We will use the Apply stage instead in pipedv1.

Why we need it:

  • to start migrating terraform to the plugin

Which issue(s) this PR fixes:

Part of #5992

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

t-kikuc added 7 commits July 3, 2025 10:38
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc requested a review from a team as a code owner July 3, 2025 02:24
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 15 lines in your changes missing coverage. Please review.

Project coverage is 28.22%. Comparing base (8a7294e) to head (112a1a4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/plugin/terraform/main.go 0.00% 11 Missing ⚠️
.../app/pipedv1/plugin/terraform/deployment/plugin.go 93.22% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5993      +/-   ##
==========================================
+ Coverage   28.16%   28.22%   +0.06%     
==========================================
  Files         516      518       +2     
  Lines       55933    56003      +70     
==========================================
+ Hits        15754    15809      +55     
- Misses      38925    38940      +15     
  Partials     1254     1254              
Flag Coverage Δ
. 23.22% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 78.57% <78.57%> (?)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.89% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t-kikuc t-kikuc enabled auto-merge (squash) July 3, 2025 02:26
khanhtc1202
khanhtc1202 previously approved these changes Jul 3, 2025
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

},
}

ctx := context.Background()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] We can use t.Context().

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ffjlabo Thank you, I fixed:
112a1a4

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc merged commit eb367ea into master Jul 3, 2025
40 checks passed
@t-kikuc t-kikuc deleted the plugin/terraform/team-sync branch July 3, 2025 02:58
@t-kikuc t-kikuc mentioned this pull request Jul 4, 2025
7 tasks
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants