Skip to content

Use tini to remove zombie process#5997

Merged
ffjlabo merged 1 commit into
masterfrom
update-piped-and-launcher-base-image-hash
Jul 3, 2025
Merged

Use tini to remove zombie process#5997
ffjlabo merged 1 commit into
masterfrom
update-piped-and-launcher-base-image-hash

Conversation

@ffjlabo
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo commented Jul 3, 2025

What this PR does:

as title

I checked on the my local docker environment.

launcher

/ $ pstree
tini---launcher-+-piped---15*[{piped}]
                `-10*[{launcher}]

piped

/ $ pstree
tini---piped---15*[{piped}]

Why we need it:

We want to manage zombie processes, so I added tini into launcher and piped container.

Which issue(s) this PR fixes:

Fixes #5989

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@ffjlabo ffjlabo requested a review from a team as a code owner July 3, 2025 05:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.22%. Comparing base (8a7294e) to head (4319c80).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5997      +/-   ##
==========================================
+ Coverage   28.16%   28.22%   +0.06%     
==========================================
  Files         516      518       +2     
  Lines       55933    56003      +70     
==========================================
+ Hits        15754    15809      +55     
- Misses      38925    38940      +15     
  Partials     1254     1254              
Flag Coverage Δ
. 23.22% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 78.57% <ø> (?)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.89% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ffjlabo ffjlabo enabled auto-merge (squash) July 3, 2025 05:37
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks 👍

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffjlabo ffjlabo merged commit ab0b7ef into master Jul 3, 2025
40 checks passed
@ffjlabo ffjlabo deleted the update-piped-and-launcher-base-image-hash branch July 3, 2025 23:31
github-actions Bot pushed a commit that referenced this pull request Jul 4, 2025
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
ffjlabo added a commit that referenced this pull request Jul 4, 2025
* Add tini into piped-base image (#5991)

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Use tini to remove zombie process (#5997)

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

---------

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zombie processes for git commands in the launcher container

4 participants