Skip to content

[Stage Plugins] Add MetadataKeyStageDisplay and AuthorizedOperators to the SDK#6000

Merged
t-kikuc merged 3 commits into
masterfrom
plugin/command/sdk
Jul 4, 2025
Merged

[Stage Plugins] Add MetadataKeyStageDisplay and AuthorizedOperators to the SDK#6000
t-kikuc merged 3 commits into
masterfrom
plugin/command/sdk

Conversation

@t-kikuc
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc commented Jul 4, 2025

What this PR does:

  • Imported MetadataKeyStageDisplay to the SDK
  • Enabled to specify AuthorizedOperators in a plugin

I used 922941f 472e02f to use the latest pipe-cd/pipecd.

Why we need it:

  • Show stage metadata on UI like Approved by user-1, user-2, Primary: 80%, Canary: 20% flexibly.
  • Enable Control-plane validation of approvers for better UX.

Which issue(s) this PR fixes:

Part of #5367

Follows #5980 #5981

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@t-kikuc t-kikuc requested a review from a team as a code owner July 4, 2025 03:14
@t-kikuc t-kikuc marked this pull request as draft July 4, 2025 03:14
@github-actions github-actions Bot added area/go area/plugin-sdk piped-plugin-sdk labels Jul 4, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.16%. Comparing base (472e02f) to head (619eda2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6000   +/-   ##
=======================================
  Coverage   28.16%   28.16%           
=======================================
  Files         519      519           
  Lines       55937    55938    +1     
=======================================
+ Hits        15756    15757    +1     
  Misses      38931    38931           
  Partials     1250     1250           
Flag Coverage Δ
. 23.22% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.27% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.33% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 80.26% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.92% <100.00%> (+0.02%) ⬆️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

t-kikuc added 3 commits July 4, 2025 13:37
…938-472e02fa6fa1"

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc force-pushed the plugin/command/sdk branch 2 times, most recently from 221b6e5 to 619eda2 Compare July 4, 2025 04:42
@t-kikuc t-kikuc marked this pull request as ready for review July 4, 2025 04:52
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@t-kikuc t-kikuc merged commit da6fce4 into master Jul 4, 2025
40 checks passed
@t-kikuc t-kikuc deleted the plugin/command/sdk branch July 4, 2025 05:41
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants