Skip to content

Remove deprecated platform provider and cloud provider from trigger logic of pipedv1#6003

Merged
khanhtc1202 merged 1 commit into
masterfrom
remove-platform-provider-in-trigger
Jul 10, 2025
Merged

Remove deprecated platform provider and cloud provider from trigger logic of pipedv1#6003
khanhtc1202 merged 1 commit into
masterfrom
remove-platform-provider-in-trigger

Conversation

@khanhtc1202
Copy link
Copy Markdown
Member

What this PR does:

  • Remove platform provider/cloud provider from pipedv1 trigger logic
  • Add a todo reminder to remove the platform provider from the pipedv1 deployment metrics collector

Why we need it:

Should not using platform/cloud provider in pipedv1 logic

Which issue(s) this PR fixes:

Part of #5956

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

…ogic

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 requested a review from a team as a code owner July 4, 2025 07:14
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) July 4, 2025 07:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.16%. Comparing base (da6fce4) to head (caa5612).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6003   +/-   ##
=======================================
  Coverage   28.16%   28.16%           
=======================================
  Files         519      519           
  Lines       55938    55936    -2     
=======================================
  Hits        15757    15757           
+ Misses      38931    38929    -2     
  Partials     1250     1250           
Flag Coverage Δ
. 23.23% <ø> (+<0.01%) ⬆️
.-pkg-app-pipedv1-plugin-kubernetes 66.27% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.33% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 80.26% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.92% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t-kikuc t-kikuc changed the title Remove deprecated platform provider and cloud provider from trigger logic Remove deprecated platform provider and cloud provider from trigger logic of pipedv1 Jul 4, 2025
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202 khanhtc1202 merged commit 51ce3d5 into master Jul 10, 2025
40 checks passed
@khanhtc1202 khanhtc1202 deleted the remove-platform-provider-in-trigger branch July 10, 2025 06:26
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants